Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix(flexbox): Add default display property to getDisplayStyle() #301

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

joshwiens
Copy link
Contributor

  • Prevents a possible TypeError being thrown at value.trim() if display is undefined.
  • Defaults to block, the default display property for css container elements.

Closes #300

 - Prevents a possible TypeError being thrown at `value.trim()` if display is undefined.
 - Defaults to `block`, the default display property for css container elements.
@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit labels May 31, 2017
@kara kara added pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs presubmit labels Jun 12, 2017
@kara kara merged commit 771f2c9 into angular:master Jun 12, 2017
@joshwiens joshwiens deleted the d3viant0ne-getDisplayStyleFix branch June 12, 2017 22:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falsy checking "display" in _getDisplayStyle
4 participants