Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Improve flex css prefixes #276

Merged
merged 1 commit into from
May 10, 2017
Merged

Conversation

karlhaas
Copy link
Contributor

@karlhaas karlhaas commented May 4, 2017

With the following changes the layout of our application works in iOS8

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label May 4, 2017
@ThomasBurleson
Copy link
Contributor

@karlhaas - you will need to sign the Google CLA before any merges can occur.

@karlhaas
Copy link
Contributor Author

karlhaas commented May 4, 2017

When I follow the link it tells me "It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below."

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels May 4, 2017
@ThomasBurleson
Copy link
Contributor

@karlhaas - nice work sir!

@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed in-progress labels May 4, 2017
@ThomasBurleson
Copy link
Contributor

@karlhaas - plz squash your commits.

@karlhaas karlhaas force-pushed the fix-display-prefixes-v3 branch from 46531a9 to 5112c9d Compare May 4, 2017 12:33
@ThomasBurleson ThomasBurleson added pr: needs presubmit and removed pr: merge ready This PR is ready for the caretaker to presubmit and merge labels May 4, 2017
@karlhaas
Copy link
Contributor Author

karlhaas commented May 6, 2017

@ThomasBurleson commits squashed

@kara kara added pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs presubmit labels May 10, 2017
@kara kara merged commit beb5ed0 into angular:master May 10, 2017
@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented May 10, 2017

@karlhaas - We are concerned about some performance impacts with this PR.

  • This PR was for iOS8 ? Did this address and any other issues
  • I do not see a Github Issue associated with this btw.

@karlhaas
Copy link
Contributor Author

@ThomasBurleson for our application (feedbackr.io) it is very important to support as many devices as possible. According to http://caniuse.com/#feat=flexbox still many browsers need css prefixes for flex.
iOS8 is just one example which I used to test the changes.

Another option (which we don't really want) would not to use flex layout and material for this part of the application.

Could you provide some information regarding the performance impacts? Maybe we can provide a better solution.

@ThomasBurleson
Copy link
Contributor

@karlhaas - see #282.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: merge ready This PR is ready for the caretaker to presubmit and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants