This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
fix(build): support Angular 4 and AOT #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
changed the title
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3. * Fixes a few linter errors. * Fixes an issue that prevented AoT from working under Angular 4. * Moves away from a few of the APIs that were deprecated in Angular 4. * Fixes issues with the testing setup which prevented the module from compiling with Angular 4. * Fixes the demo app not working properly due to the Material theme not being included correctly. Fixes angular#254, angular#236, angular#227.
This was referenced Apr 12, 2017
|
Presubmit error: in |
|
That looks weird @jelbourn, it works for me locally. Also I did the same logic for Material 2 when I was migrating to the new renderer. |
|
@crisbeto Yeah, I'm not sure why this error is occurring. It only happens in one project, the rest all pass. I'll try to investigate whether they're doing something weird. |
|
@kara - we really need to get this merged asap! |
|
We are looking into a related Google test failure now. Working as fast as
we can :) promise it will be in once we can get tests passing.
…On Apr 17, 2017 8:20 PM, "Thomas Burleson" ***@***.***> wrote:
@kara <https://github.com/kara> - we really need to get this merged asap!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADsTyENNC-ND6vzbrrCEO2HB9KSS-LDdks5rxCvjgaJpZM4M7qxd>
.
|
kara
added
pr: merge ready
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angulardependencies to 4 and Material to 2.0.0-beta.3.BREAKING CHANGE:
These changes to @angular/flex-layout will require Angular v4.x and will not be compatible with Angular v2.x.
Fixes #254, #236, #227.