Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy presubmit script doesn't run with Ivy if ng_module.bzl is edited #1

Closed
kara opened this issue Jun 28, 2019 · 2 comments
Closed
Assignees

Comments

@kara
Copy link

kara commented Jun 28, 2019

If the presubmit diff edits the ng_module.bzl file in some way, the diff from the flip CL isn't applied to the file, and the presubmit runs with VE instead of Ivy.

@josephperrott josephperrott self-assigned this Jun 28, 2019
@josephperrott
Copy link
Member

Fixed by change 255633330

@github-actions
Copy link

github-actions bot commented Sep 3, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants