From 92778223953e029d1723febf282bb265b4e2a56f Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Thu, 21 Oct 2021 23:13:35 +0200 Subject: [PATCH] Revert "build: use nvmrc version to set node version in WORKSPACE (#259)" (#274) This reverts commit 4fee0078e72cbc6cdff9eb63a90e79a0529f4404. Commit is reverted because the nvmrc file does not work due to recent changes in `rules_nodejs`. The Bazel NodeJS rules need to compute the Node version at analysis time within Starlark as otherwise the proper toolchains would not be configured, and the fallback Node 14 version would be used. PR Close #274 --- WORKSPACE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WORKSPACE b/WORKSPACE index e51288218..9a2484f77 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -26,7 +26,7 @@ http_archive( load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install") node_repositories( - use_nvmrc = "//:.nvmrc", + node_version = "16.10.0", ) yarn_install(