Add support for drawing tick marks on the slider #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| } | ||
|
|
||
| set tickInterval(v: 'auto' | number) { | ||
| if (v == 'auto') { |
There was a problem hiding this comment.
You can safely ignore this if and straight do this._tickInterval = v
iveysaur
changed the title
|
@jelbourn: Addressed comments. |
|
|
||
| // This calculates which step is far enough away from the beginning of the slider to draw a tick | ||
| // at. This value will then be used to draw ticks at every tickStep steps. | ||
| let tickStep = |
There was a problem hiding this comment.
I think this would benefit from some more explanation as to where the calculation came from.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tick interval to slider. A tick interval of
autowill find a tick separation of at least 30px, otherwise the tick separation value is calculated by the number given.The tick interval is based off of the step, meaning a slider with a step of 3 and a tick interval of 4 will draw ticks every 4 steps/every 12 values.
A tick is always drawn at the end of a slider, with the second to last tick being removed if it is too close to the last one.
A repeating linear background is used to draw the ticks because I believe it is more performant/easier than creating multiple divs or using a canvas. This needs to be tested still.
R: @jelbourn @kara
CC: @hansl @robertmesserle