feat(stepper): Merge initial prototype of stepper into the upstream stepper branch. #5742

g1shin · 2017-07-13T20:48:13Z

No description provided.

…let.

mmalerba · 2017-07-13T21:30:17Z

src/cdk/stepper/step.ts

+    templateUrl: 'step.html',
+})
+export class CdkStep {
+    @ContentChild(CdkStepLabel) stepLabel: CdkStepLabel;


\n (and comment what these are)

mmalerba · 2017-07-13T21:32:27Z

src/cdk/stepper/step.ts

+    label: string;
+
+    /** Whether the step is optional or not. */
+    @Input() optional: boolean = false;


split into setter & getter, and use coerceBooleanProperty

mmalerba · 2017-07-13T21:32:46Z

src/cdk/stepper/step.ts

+    @Input() optional: boolean = false;
+
+    /** Whether the step is editable or not. */
+    @Input() editable: boolean = true;


use coerceBooleanProperty

mmalerba · 2017-07-13T21:33:32Z

src/cdk/stepper/step.ts

+    /** Whether the step is the last one in the list. */
+    isLast: boolean = false;
+
+    // /** Whether the step is active. */


no longer needed?

mmalerba · 2017-07-13T21:34:36Z

src/cdk/stepper/step.ts

+    @Input() editable: boolean = true;
+
+    /** Whether the step is the last one in the list. */
+    isLast: boolean = false;


is this something we want to be part of the public API? (I asusme probably not, but we can't make it private since its referenced in a template file, so instead check to _isLast)

mmalerba · 2017-07-13T21:53:19Z

src/cdk/stepper/stepper.ts

+    }
+
+    /** Selects and focuses the provided step. */
+    selectStep(step: CdkStep): void {


Is this similar to what tabs does? From an API perspective I would rather CdkStep have a select method, but I could see maybe not wanting a dependency from child to parent

No, it seems like tabs doesn't have a separate method for selecting. It just updates and sets the selectedIndex in the html file. Since the CdkStepper already takes care of all the logic regarding the selection and selectedIndex tracking, I was thinking about just getting rid of the selected attribute completely from CdkStep.

I'm saying that as an API I prefer: step.select() to stepper.select(step), but this would require the step to know about its parent stepper, so maybe not worth it. @jelbourn do you have any opinion?

mmalerba · 2017-07-13T21:54:17Z

src/cdk/stepper/stepper.ts

+    private _selectedStep: CdkStep;
+
+    /** The index of the step that the focus is currently on. */
+    get focusIndex(): number {return this._focusIndex; }


do we need a public API for this? seems like an internal detail

mmalerba · 2017-07-13T21:54:45Z

src/cdk/stepper/stepper.ts

+    }
+
+    /** Selects and focuses the next step in list. */
+    nextStep(): void {


I would just call it next and previous

mmalerba · 2017-07-13T21:55:31Z

src/cdk/stepper/stepper.ts

+    _onKeydown(event: KeyboardEvent) {
+        switch (event.keyCode) {
+            case RIGHT_ARROW:
+                if (this._focusIndex != this._steps.length - 1) {


just call nextStep?

This wouldn't be equivalent to nextStep because RIGHT_ARROW does not mean that the next step has been chosen. Only the focus has changed. The user would need to press ENTER to make the actual selection change.

mmalerba · 2017-07-13T21:57:25Z

src/cdk/stepper/stepper.ts

+        return `mat-step-content-${this._groupId}-${i}`;
+    }
+
+    private _emitStepEvent(index: number): CdkStepEvent {


name is deceptive since this method doesn't actually cause an emit

jelbourn · 2017-07-20T18:55:13Z

src/cdk/stepper/stepper.ts

+  newIndex: number;
+
+  /** The index of the step that was previously selected. */
+  oldIndex: number;


How about selectedIndex and previouslySelectedIndex (and selectedStep and previouslySelectedStep)?

jelbourn · 2017-07-20T18:56:29Z

src/cdk/stepper/stepper.ts

+  @ContentChildren(CdkStep) _steps: QueryList<CdkStep>;
+
+  /** The list of step headers of the steps in the stepper. */
+  @ViewChildren('stepHeader') _stepHeader: QueryList<ElementRef>;


Yeah, requiring a specific template variable to exist isn't a great API

jelbourn · 2017-07-20T18:57:52Z

src/cdk/stepper/stepper.ts

+@Directive({
+  selector: 'cdk-stepper',
+  host: {
+    '(focus)': '_setStepfocused()',


_setStepFocused

jelbourn · 2017-07-20T18:58:51Z

src/cdk/stepper/stepper.ts

+  set selectedIndex(index: number) {
+    if (this._selectedIndex == index) { return; }
+    this._emitStepperSelectionEvent(index);
+    this._setStepFocused(this._selectedIndex);


Rather than using a return, I'd structure it like

if (this._selectedIndex != index) { this._emitStepperSelectionEvent(index); this._setStepFocused(this._selectedIndex); }

(I find return to be weird inside of a setter)

jelbourn · 2017-07-20T19:02:14Z

src/cdk/stepper/stepper.ts

+  /** Selects and focuses the next step in list. */
+  next(): void {
+    if (this._selectedIndex == this._steps.length - 1) { return; }
+    this.selectedIndex++;


this._selectedIndex = Math.min(this._selectedIndex + 1, this._steps.length - 1);

jelbourn · 2017-07-20T19:08:06Z

src/cdk/stepper/stepper.ts

+  _onKeydown(event: KeyboardEvent) {
+    switch (event.keyCode) {
+      case RIGHT_ARROW:
+        this._setStepFocused((this._focusIndex + 1) % this._steps.length);


Can you file an issue on github to track creating something like a TabsKeyManager to reduce duplication between tabs and stepper?

jelbourn · 2017-07-20T19:09:14Z

src/lib/stepper/stepper-horizontal.html

+
+    <div class="mat-stepper-label">
+      <!-- If there is a label template, use it. -->
+      <ng-container *ngIf="step.stepLabel"[ngTemplateOutlet]="step.stepLabel.template">


Missing space between attributes

jelbourn · 2017-07-20T19:09:48Z

src/lib/stepper/stepper-horizontal.html

+</div>
+<div>
+  <button md-button (click)="previous()">Back</button>
+  <button md-button (click)="next()">Next</button>


Are these buttons just here for testing / development?

This PR doesn't include stepper-button directives that will be used by users to add the buttons themselves. The stepper component in this initial PR inserts the buttons instead. The stepper-button directives will come in the next PR since this is already too big, and these buttons will be removed in that PR as well.

Sounds good, just add a comment mentioning that

jelbourn · 2017-07-20T19:10:20Z

src/lib/stepper/stepper-horizontal.ts

+    'class': 'mat-stepper-horizontal',
+    'role': 'tablist',
+  },
+  providers: [{ provide: MdStepper, useExisting: forwardRef(() => MdHorizontalStepper) }]


Is the forwardRef necessary here?

jelbourn · 2017-07-20T19:10:40Z

src/lib/stepper/stepper-vertical.html

+    <ng-container [ngTemplateOutlet]="step.content"></ng-container>
+    <div>
+      <button md-button (click)="previous()">Back</button>
+      <button md-button (click)="next()">Next</button>


Same question for these buttons

Same plan for these buttons as well.

g1shin · 2017-07-20T22:19:17Z

Changes have been made; ready for review.

mmalerba · 2017-07-20T22:23:37Z

src/cdk/stepper/stepper.ts

+
+  /** Returns the step that is selected. */
+  get selected() { return this._steps[this.selectedIndex]; }
+  /** Sets selectedIndex as the index of the provided step. */


nit: can just put 1 comment for set & get since they represent the same property

mmalerba · 2017-07-20T22:25:46Z

src/cdk/stepper/stepper.ts

+  _stepHeader: QueryList<ElementRef>;
+
+  /** The index of the selected step. */
+  get selectedIndex() { return this._selectedIndex; }


we want this to be an @Input() right?

mmalerba · 2017-07-20T22:26:10Z

src/cdk/stepper/stepper.ts

+  private _selectedIndex: number = 0;
+
+  /** Returns the step that is selected. */
+  get selected() { return this._steps[this.selectedIndex]; }


same, should be @Input()

mmalerba · 2017-07-20T22:35:17Z

src/lib/stepper/stepper-horizontal.html

+      <div *ngIf="!step.stepLabel">{{step.label}}</div>
+    </div>
+
+    </ng-template>


don't see a corresponding opening tag for this?

mmalerba · 2017-07-20T22:35:39Z

src/lib/stepper/stepper-horizontal.html

@@ -0,0 +1,35 @@
+<div *ngFor="let step of _steps; let i = index; let isLast = last">


why do we need this wrapper div, is it supposed to contain all of the headers?

jelbourn · 2017-07-20T23:22:09Z

src/cdk/stepper/index.ts

+import {PortalModule} from '../portal';
+
+@NgModule({
+  imports: [CommonModule, PortalModule],


I think you can remove PortalModule since it doesn't look to be used anywhere

jelbourn · 2017-07-20T23:39:22Z

src/cdk/stepper/step-label.ts

+import {Directive, TemplateRef} from '@angular/core';
+
+@Directive({
+  selector: 'cdk-step-label',


I think this has to be an attribute because it needs to be applied to an ng-template element. As an attribute it would be cdkStepLabel

jelbourn · 2017-07-20T23:41:32Z

src/cdk/stepper/stepper.ts

+
+/** Change event emitted on selection changes. */
+export class CdkStepperSelectionEvent {
+  /** The index of the step that is newly selected during this change event. */


Can be shortened to

/** Index of the step now selected. */

jelbourn · 2017-07-20T23:42:29Z

src/cdk/stepper/stepper.ts

+  /** The index of the step that is newly selected during this change event. */
+  selectedIndex: number;
+
+  /** The index of the step that was previously selected. */


"Index of the step previously selected."

jelbourn · 2017-07-20T23:43:00Z

src/cdk/stepper/stepper.ts

+  /** The index of the step that was previously selected. */
+  previouslySelectedIndex: number;
+
+  /** The new step component that is selected ruing this change event. */


"The step instance now selected"

jelbourn · 2017-07-20T23:43:09Z

src/cdk/stepper/stepper.ts

+  /** The new step component that is selected ruing this change event. */
+  selectedStep: CdkStep;
+
+  /** The step component that was previously selected. */


"The step instance previously selected"

jelbourn · 2017-07-21T00:09:49Z

src/cdk/stepper/stepper.ts

+    event.preventDefault();
+  }
+
+  private _setStepFocused(index: number) {


Since you're actually calling focus, I'd just call this method _focusStep

jelbourn · 2017-07-21T00:11:38Z

src/lib/stepper/stepper-horizontal.html

+</div>
+<div>
+  <button md-button (click)="previous()">Back</button>
+  <button md-button (click)="next()">Next</button>


Sounds good, just add a comment mentioning that

jelbourn · 2017-07-21T00:12:21Z

src/lib/stepper/stepper-vertical.ts

+    'class': 'mat-stepper-vertical',
+    'role': 'tablist',
+  },
+  providers: [{ provide: MdStepper, useExisting: MdVerticalStepper }]


Omit spaces inside braces, e.g.,

[{provide: MdStepper, useExisting: MdVerticalStepper}]

g1shin · 2017-07-21T00:45:35Z

Ready for review again.

mmalerba

LGTM. Thanks for being patient with the long review. Please wait for any final comments from @jelbourn and @kara before merging

jelbourn

Just a few last minor comments

jelbourn · 2017-07-21T16:06:13Z

src/demo-app/stepper/stepper-demo.html

+      <input mdInput placeholder="Answer" [(ngModel)]="step.content">
+    </md-input-container>
+  </mat-step>
+</mat-horizontal-stepper>


Just noticed that the stepper selectors need to be added to the compatibility mode list as well
(which enforces that you use either md- or mat- and not both)

jelbourn · 2017-07-21T16:06:55Z

src/lib/stepper/step.ts

+  templateUrl: 'step.html',
+})
+export class MdStep extends CdkStep {
+  /** Content for the step label given by <ng-template mat-step-label>. */


Select in comment still uses dashes

jelbourn · 2017-07-21T16:08:56Z

src/lib/stepper/stepper-horizontal.ts

+})
+export class MdHorizontalStepper extends MdStepper {
+  /** Steps that the horizontal stepper holds. */
+  @ContentChildren(MdStep) _steps: QueryList<MdStep>;


Both MdHorizontalStepper and MdVerticalStepper have

@ContentChildren(MdStep) _steps: QueryList<MdStep>;

Could that go in the MdStepper base class?

Yes, I moved _steps to MdStepper base class. However, this resulted in circular dependency between MdStepper and MdStep, so I moved MdStep into stepper.ts as it's done for CdkStep.

jelbourn · 2017-07-21T16:09:17Z

src/lib/stepper/stepper.scss

@@ -0,0 +1,7 @@
+.mat-stepper-content[aria-expanded='false'] {
+  display:none;


Missing space

g1shin · 2017-07-21T17:55:13Z

Thank you for all the comments on this big PR. Comments were addressed; ready for another review.

…tepper branch. (#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency

…tepper branch. (angular#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency

…tepper branch. (#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency

@input

…tepper branch. (#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency feat(stepper): Create stepper button directives to enable adding buttons to stepper (#5951) * Create stepper button directives to enable adding buttons to stepper * Changes made based on review * Minor changes with click handlers Build changes feat(stepper): Add initial styles to stepper based on Material guidelines (#6242) * Add initial styles to stepper based on Material guidelines * Fix flex-shrink and min-width * Changes made based on review * Fix alignment * Margin modifications feat(stepper): Add support for linear stepper (#6116) * Add form controls and custom error state matcher * Modify form controls for stepper-demo and add custom validator * Move custom step validation function so that users can simply import and use * Implement @input() stepControl for each step * Add linear attribute to stepper * Add enabling/disabling linear state of demo feat(stepper): Add animation to stepper (#6361) * Add animation * Implement Angular animation * Clean up unnecessary code * Generalize animation so that vertical and horizontal steppers can use the same function Rebase onto upstream/master feat(stepper): Add unit tests for stepper (#6428) * Add unit tests for stepper * Changes made based on review * More changes based on review feat(stepper): Add support for linear stepper #2 - each step as its own form. (#6117) * Add form control - consider each step as its own form group * Comment edits * Add 'valid' to MdStep for form validation * Add [stepControl] to each step based on merging * Changes based on review Fix focus logic and CSS changes (#6507) feat(stepper): Add documentation for stepper (#6533) * Documentation for stepper * Revision based on review + add accessibility section feat(stepper): Support additional properties for step (#6509) * Additional properties for step * Unit tests * Code changes based on review + test name changes * Refactor code for shared functionality between vertical and horizontal stepper * Refactor md-step-header and md-step-content + optional step change * Simplify code based on review * Changes to step-header based on review * Minor changes Fix host style and demo page (#6592) Revert package.json and package-lock.json Changes made along with BUILD changes in google3 Add typography mixin Changes to address aot compiler failures fix rtl bugs

@input

…tepper branch. (angular#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency feat(stepper): Create stepper button directives to enable adding buttons to stepper (angular#5951) * Create stepper button directives to enable adding buttons to stepper * Changes made based on review * Minor changes with click handlers Build changes feat(stepper): Add initial styles to stepper based on Material guidelines (angular#6242) * Add initial styles to stepper based on Material guidelines * Fix flex-shrink and min-width * Changes made based on review * Fix alignment * Margin modifications feat(stepper): Add support for linear stepper (angular#6116) * Add form controls and custom error state matcher * Modify form controls for stepper-demo and add custom validator * Move custom step validation function so that users can simply import and use * Implement @input() stepControl for each step * Add linear attribute to stepper * Add enabling/disabling linear state of demo feat(stepper): Add animation to stepper (angular#6361) * Add animation * Implement Angular animation * Clean up unnecessary code * Generalize animation so that vertical and horizontal steppers can use the same function Rebase onto upstream/master feat(stepper): Add unit tests for stepper (angular#6428) * Add unit tests for stepper * Changes made based on review * More changes based on review feat(stepper): Add support for linear stepper angular#2 - each step as its own form. (angular#6117) * Add form control - consider each step as its own form group * Comment edits * Add 'valid' to MdStep for form validation * Add [stepControl] to each step based on merging * Changes based on review Fix focus logic and CSS changes (angular#6507) feat(stepper): Add documentation for stepper (angular#6533) * Documentation for stepper * Revision based on review + add accessibility section feat(stepper): Support additional properties for step (angular#6509) * Additional properties for step * Unit tests * Code changes based on review + test name changes * Refactor code for shared functionality between vertical and horizontal stepper * Refactor md-step-header and md-step-content + optional step change * Simplify code based on review * Changes to step-header based on review * Minor changes Fix host style and demo page (angular#6592) Revert package.json and package-lock.json Changes made along with BUILD changes in google3 Add typography mixin Changes to address aot compiler failures fix rtl bugs

@input

…tepper branch. (angular#5742) * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Adding "selectedIndex" attribute to stepper and working on TemplateOulet. * Prototyping * Further work * Further prototyping * Further prototyping * Further work * Adding event emitters * Template rendering and selectIndex control done. * Work in progress for accessibility * Added functionalities based on the tentative API doc. * Refactor code for cdk-stepper and cdk-step * Add support for templated label * Added support for keyboard events and focus changes for accessibility. * Updated vertical stepper + added comments * Fix package-lock.json * Fix indention * Changes made based on the review * Changes based on review - event properties, selectors, SPACE support, etc. + demo * Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys * API change based on review * Minor code clean up based on review. * Several name changes, etc based on review * Add to compatibility mode list and refactor to avoid circular dependency feat(stepper): Create stepper button directives to enable adding buttons to stepper (angular#5951) * Create stepper button directives to enable adding buttons to stepper * Changes made based on review * Minor changes with click handlers Build changes feat(stepper): Add initial styles to stepper based on Material guidelines (angular#6242) * Add initial styles to stepper based on Material guidelines * Fix flex-shrink and min-width * Changes made based on review * Fix alignment * Margin modifications feat(stepper): Add support for linear stepper (angular#6116) * Add form controls and custom error state matcher * Modify form controls for stepper-demo and add custom validator * Move custom step validation function so that users can simply import and use * Implement @input() stepControl for each step * Add linear attribute to stepper * Add enabling/disabling linear state of demo feat(stepper): Add animation to stepper (angular#6361) * Add animation * Implement Angular animation * Clean up unnecessary code * Generalize animation so that vertical and horizontal steppers can use the same function Rebase onto upstream/master feat(stepper): Add unit tests for stepper (angular#6428) * Add unit tests for stepper * Changes made based on review * More changes based on review feat(stepper): Add support for linear stepper angular#2 - each step as its own form. (angular#6117) * Add form control - consider each step as its own form group * Comment edits * Add 'valid' to MdStep for form validation * Add [stepControl] to each step based on merging * Changes based on review Fix focus logic and CSS changes (angular#6507) feat(stepper): Add documentation for stepper (angular#6533) * Documentation for stepper * Revision based on review + add accessibility section feat(stepper): Support additional properties for step (angular#6509) * Additional properties for step * Unit tests * Code changes based on review + test name changes * Refactor code for shared functionality between vertical and horizontal stepper * Refactor md-step-header and md-step-content + optional step change * Simplify code based on review * Changes to step-header based on review * Minor changes Fix host style and demo page (angular#6592) Revert package.json and package-lock.json Changes made along with BUILD changes in google3 Add typography mixin Changes to address aot compiler failures fix rtl bugs

angular-automatic-lock-bot · 2019-09-06T18:01:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jwshinjwshin added 21 commits July 6, 2017 09:20

Prototyping

33c6299

Further work

366b4c3

Further prototyping

d8e3075

Further prototyping

f94d966

Further work

23bfd0c

Adding event emitters

63d141e

Adding "selectedIndex" attribute to stepper and working on TemplateOu…

471df0f

…let.

Prototyping

1d6ebb2

Further work

03e5849

Further prototyping

c1cb73f

Further prototyping

e90c839

Further work

992a07a

Adding event emitters

9e5720a

Merge branch 'stepper1' of github.com:g1shin/material2 into stepper1

66bec54

Template rendering and selectIndex control done.

617c270

Work in progress for accessibility

42c1f14

Added functionalities based on the tentative API doc.

b879732

Refactor code for cdk-stepper and cdk-step

f89b8bc

Add support for templated label

a529bf3

Added support for keyboard events and focus changes for accessibility.

34ac69e

Updated vertical stepper + added comments

aee0abf

g1shin requested review from kara and mmalerba July 13, 2017 20:48

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 13, 2017

jwshinjwshin added 3 commits July 13, 2017 14:03

Merge remote-tracking branch 'upstream/master' into stepper2

fcb94ff

Fix package-lock.json

5e9085f

Fix indention

f417435

mmalerba reviewed Jul 13, 2017

View reviewed changes

g1shin assigned kara and mmalerba Jul 14, 2017

g1shin force-pushed the stepper2 branch from ac21228 to ef96e2e Compare July 19, 2017 21:22

API change based on review

26f73f9

g1shin force-pushed the stepper2 branch from ef96e2e to 26f73f9 Compare July 19, 2017 21:26

jelbourn reviewed Jul 20, 2017

View reviewed changes

Minor code clean up based on review.

a56e57f

mmalerba reviewed Jul 20, 2017

View reviewed changes

jelbourn reviewed Jul 21, 2017

View reviewed changes

Several name changes, etc based on review

3c1f4fd

g1shin force-pushed the stepper2 branch from 918b503 to 3c1f4fd Compare July 21, 2017 00:44

mmalerba approved these changes Jul 21, 2017

View reviewed changes

jelbourn reviewed Jul 21, 2017

View reviewed changes

Add to compatibility mode list and refactor to avoid circular dependency

0c3f7c4

mmalerba added the pr: lgtm label Jul 21, 2017

mmalerba approved these changes Jul 21, 2017

View reviewed changes

g1shin merged commit 4438480 into angular:stepper Jul 21, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

		@@ -0,0 +1,35 @@
		<div *ngFor="let step of _steps; let i = index; let isLast = last">

		@@ -0,0 +1,7 @@
		.mat-stepper-content[aria-expanded='false'] {
		display:none;

feat(stepper): Merge initial prototype of stepper into the upstream stepper branch. #5742

feat(stepper): Merge initial prototype of stepper into the upstream stepper branch. #5742

Conversation

g1shin commented Jul 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

g1shin Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

g1shin commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

g1shin commented Jul 21, 2017

mmalerba left a comment

Choose a reason for hiding this comment

jelbourn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

g1shin commented Jul 21, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

g1shin Jul 20, 2017 •

edited

Loading