Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[overlay] keyboard event dispatcher #6330

Closed
willshowell opened this issue Aug 7, 2017 · 1 comment · Fixed by #6682
Closed

[overlay] keyboard event dispatcher #6330

willshowell opened this issue Aug 7, 2017 · 1 comment · Fixed by #6682
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@willshowell
Copy link
Contributor

willshowell commented Aug 7, 2017

Bug, feature request, or proposal:

Feature

Motivation

If focus is not one of an overlay component's focusable elements, keyboard events will land on the body and context is loss for which overlay component should have been targeted.

More specifically, something like this will later enable dialog users to respond to targeted escape events with only a DialofRef instance. See #3460 (comment) and preceding 4-5 comments.

It feels like there needs to be a more involved keyboard event dispatcher for overlays. Probably one listener on the body that dispatches the event to the appropriate overlay based on some combination of event origin and open order (maybe with a separate priority mechanism).

Reproduction of keydown target issue

https://plnkr.co/edit/puYeeRCta8A7moZOPRWI?p=preview

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Aug 17, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants