-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure easing curves and shadows are on-spec #48
Comments
In _shadows.scss this link is provided as documentation for shadows In the new spec the link should be http://www.google.com/design/spec/what-is-material/elevation-shadows.html I think there are differences in shadows. |
mdElevation Design Doc: https://docs.google.com/document/d/1W3NGSLqDZzjbBBLW2C6y_6NUxtvdZAVaJvg58LY3Q0E/edit?usp=sharing |
This commit replaces `_shadows.scss` within `src/core/styles` with `_elevation.scss`, according to the proposed design outlined [here](https://goo.gl/Kq0k9Z). All components that were dependent on the old shadows have been modified to use elevation. Note however that none of the values in those old components have been changed; it's simply a to the new API. Part of angular#48.
This commit replaces `_shadows.scss` within `src/core/styles` with `_elevation.scss`, according to the proposed design outlined [here](https://goo.gl/Kq0k9Z). All components that were dependent on the old shadows have been modified to use elevation. Note however that none of the values in those old components have been changed; it's simply a to the new API. Part of angular#48.
This commit replaces `_shadows.scss` within `src/core/styles` with `_elevation.scss`, according to the proposed design outlined [here](https://goo.gl/Kq0k9Z). All components that were dependent on the old shadows have been modified to use elevation. Note however that none of the values in those old components have been changed; it's simply a to the new API. Part of #48. Closes #222
Done for elevation. |
@mmalerba the task here is to make sure all the timings and curves we're using are on-spec and shared between components. This is a lower-priority item for beta. |
Sorry, didn't mean to close this. Interesting part of the spec related to animations is dynamic durations: https://material.googleplex.com/motion/duration-easing.html#duration-easing-dynamic-durations (the idea that the duration changes based on the size of your device). Is this something we want to include in our implementation? |
I hadn't seen that before. I'd consider that a "nice-to-have" for now, something we can refine later. |
pr for shadows: #1857 still need to do animations |
Hello from the future! I don't know if anybody is still subscribed, but I came here to find out how material2 handles changing its animation timing based on device type (as the spec requires) -- looks like maybe the answer at this time is that you don't? Should I open a new ticket to bring timing in line with the spec or would it be better to reopen this one? I am still trying to figure out how to actually decide what timing to use in my own animations. Best I have right now is:
It's far from perfect but I don't know if we can get any better information to make the decision. |
* make sidenav shell look like mocks * toolbar shadow * fix lint * category list styles * component list styles
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Current easing curves and shadows are pulled from Angular 1 version. We need to double check that these reflect the current state of the spec.
The text was updated successfully, but these errors were encountered: