Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdSlider prevents compiling with AoT #1657

Closed
borislemke opened this issue Oct 31, 2016 · 4 comments
Closed

MdSlider prevents compiling with AoT #1657

borislemke opened this issue Oct 31, 2016 · 4 comments

Comments

@borislemke
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Compile project with AoT

What is the current behavior?

Compilation fails due to MdSlider's _tickInterval being private

What are the steps to reproduce?

Compile with ngc
ngc -p src/tsconfig-aot.json
Returns:

Error at ~someDevPath/src/aot/node_modules/@angular2-material/slider/slider.ngfactory.ts:106:20: Property '_tickInterval' is private and only accessible within class 'MdSlider'.
    at check (~someDevPath/node_modules/@angular/tsc-wrapped/src/tsc.js:31:15)
    at Tsc.typeCheck (~someDevPath/node_modules/@angular/tsc-wrapped/src/tsc.js:86:9)
    at ~someDevPath/node_modules/@angular/tsc-wrapped/src/main.js:33:23
    at process._tickCallback (internal/process/next_tick.js:103:7)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3
Compilation failed

What is the use-case or motivation for changing an existing behavior?

Make compile with AoT work

Which versions of Angular, Material, OS, browsers are affected?

angular-cli: 1.0.0-beta.18
node: 6.9.1
os: darwin x64

@angular2-material 2.0.0-alpha.8-2

Is there anything else we should know?

@alsami
Copy link

alsami commented Oct 31, 2016

AFAIK it's because the inputs/outputs where marked as private which won't work with AOT.
They already changed that, guess we need to wait for Alpha10.

see #1636 for instance.

@jelbourn
Copy link
Member

jelbourn commented Nov 1, 2016

This was fixed in 833368f, which should be included in the current release (alpha.9-3)

@jelbourn jelbourn closed this as completed Nov 1, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 1, 2016

Also note that new releases are being done on @angular/material instead of the previous @angular2-material

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants