Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest add user-select: none to [button-toggle] #1086

Closed
colinfang opened this issue Aug 19, 2016 · 2 comments · Fixed by #1720
Closed

Suggest add user-select: none to [button-toggle] #1086

colinfang opened this issue Aug 19, 2016 · 2 comments · Fixed by #1720
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@colinfang
Copy link

colinfang commented Aug 19, 2016

Since button-toggle appears like buttons, I suggest user-select should be disabled. (Maybe in .md-button-toggle-label-content)

        -webkit-user-select: none;
        -moz-user-select: none;
        -ms-user-select: none;
        user-select: none;
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Aug 31, 2016
@fxck
Copy link
Contributor

fxck commented Oct 21, 2016

Is this really needed? The default value for actual button element is user-select: text, in desktop browser anyway, is it any different in mobile browsers? Also is this really needed, what action should it prevent?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants