Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular latest RC (and make version less restrictive) #272

Closed
jeffbcross opened this issue Jun 22, 2016 · 3 comments
Closed

Update to Angular latest RC (and make version less restrictive) #272

jeffbcross opened this issue Jun 22, 2016 · 3 comments
Assignees
Milestone

Comments

@jeffbcross
Copy link
Contributor

No description provided.

@jeffbcross jeffbcross added this to the Beta.3 milestone Jun 22, 2016
@jtushar53
Copy link

i'm using ionic 2 beta 10 which uses angular rc3, tried upgrading angularfire2 manually from package.json

getting below error while bootstrapping
reflective_provider.js:163 Uncaught Invalid provider - only instances of Provider and Type are allowed, got: [object Object]

any workaround would be great

@jeffbcross jeffbcross changed the title Update to Angular RC.3 Update to Angular latest RC (and make version less restrictive) Jun 30, 2016
@jeffbcross
Copy link
Contributor Author

Changed to Rc.4 but perhaps we should make the version restriction more permissive to accept any RC version. I think we can use || in the version to match current and future versions of RC, according to @samccone who would never lie to me.

Since AngularFire just uses some Dependency Injection from Angular, and DI is stable in Angular, it should be safe to include future versions of RC as acceptable.

@samccone
Copy link

😘

@jeffbcross jeffbcross self-assigned this Jun 30, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jun 30, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants