Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): fix URLSearchParams clone method to include subclassed Que… #9900

Merged
merged 1 commit into from
Jul 31, 2016

Conversation

Cody-Nicholson
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The URLSearchParams clone method will not properly preserve a subclassed QueryEncoder. This prevents any HTTP method from using a subclassed QueryEncoder via RequestOptionsArgs.

What is the new behavior?
The URLSearchParams clone method will properly preserve subclassed QueryEncoders.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…ryEncoder

@Cody-Nicholson Cody-Nicholson force-pushed the fix-url-search-params-clone branch from 4c34e51 to d15749e Compare July 8, 2016 16:02
@vicb vicb merged commit 2519532 into angular:master Jul 31, 2016
@Cody-Nicholson Cody-Nicholson deleted the fix-url-search-params-clone branch August 16, 2016 16:00
hbkrunal pushed a commit to hbkrunal/angular that referenced this pull request Sep 15, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants