refactor(core): remove deprecated parameter for ErrorHandler
#18759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
area: core
vicb
suggested changes
Aug 17, 2017
packages/core/src/error_handler.ts
Outdated
| * rethrow. | ||
| */ | ||
| deprecatedParameter?: boolean) {} | ||
| constructor() {} |
BREAKING CHANGE: `ErrorHandler` no longer takes a parameter as it was not used and deprecated since v4.
ocombe
force-pushed
the
remove-error-handler-parameter
branch
from
a49542d to
06e2ea4
Compare
|
You can preview a49542d at https://pr18759-a49542d.ngbuilds.io/. |
vicb
approved these changes
Aug 17, 2017
|
You can preview 06e2ea4 at https://pr18759-06e2ea4.ngbuilds.io/. |
ocombe
added
action: merge
mhevery
approved these changes
Aug 17, 2017
|
Parameter was used for whether to re-throw errors, see #15208 |
|
It was no longer used since v4, see the PR that you linked. |
|
Yes @ocombe, since 4.0.0-rc.4 ... went completely unnoticed to me ... It was also the only breaking change I had for migrating from v4 to v5! Cheers! 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ErrorHandlerwas taking a parameter but was not using it.What is the new behavior?
ErrorHandlerno longer takes a parameter as it was not used and deprecated since v4.Does this PR introduce a breaking change?