This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): make '='-bindings NaN-aware #8554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update parent and child scopes correctly when a '='-binding changes from a NaN value.
|
I'm just going to check this in because it's a really trivial change, and the fact that this isn't working currently can cause problems for certain weird use-cases involving ngModel, and is just generally bonkers. Will want review later, can revert or update it if any changes are asked for |
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Aug 10, 2014
Update parent and child scopes correctly when a '='-binding changes from a NaN value. TBR by angular-core Closes angular#8553 Closes angular#8554 Conflicts: test/ng/compileSpec.js
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update parent and child scopes correctly when a '='-binding changes from a NaN
value.
Closes #8553