This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): force visual update in IE #8158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE9, IE10 and IE11 would always show the first <option> as selected when the user moves from a null <option> to a non-null one in a non-null <select>. Even though the model was being updated correctly, visually, the first <option> always appeared selected. Setting the `selected` property twice in a row seems to fix it in all the three versions mentioned above. Closes angular#7692
|
You remembered to triage your own PR this time, awesome! |
rodyhaddad
added a commit
that referenced
this pull request
Jul 15, 2014
IE9, IE10 and IE11 would always show the first <option> as selected when the user moves from a null <option> to a non-null one in a non-null <select>. Even though the model was being updated correctly, visually, the first <option> always appeared selected. Setting the `selected` property twice in a row seems to fix it in all the three versions mentioned above. Closes #7692 Closes #8158
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
IE9, IE10 and IE11 would always show the first <option> as selected when the user moves from a null <option> to a non-null one in a non-null <select>. Even though the model was being updated correctly, visually, the first <option> always appeared selected. Setting the `selected` property twice in a row seems to fix it in all the three versions mentioned above. Closes angular#7692 Closes angular#8158
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE9, IE10 and IE11 would always show the first as
selected when the user moves from a null
to a non-null one in a non-null . Even though the model was being updated correctly, visually, the first always appeared selected. Setting the selected property twice in a row seems to fix it in all the three versions mentioned above. Closes #7692 I doubt we can actually write tests for this, since it's only visual