Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

"Wire the backend" example: deep link broken #5396

Closed
keyo321 opened this issue Dec 13, 2013 · 7 comments
Closed

"Wire the backend" example: deep link broken #5396

keyo321 opened this issue Dec 13, 2013 · 7 comments

Comments

@keyo321
Copy link

keyo321 commented Dec 13, 2013

Is it just me or is the layout broken when visiting a deep link on angularjs.com?
http://angularjs.org/edit/-JAgje-Pb3CM6GsvO_2A

This is a edit for the Wire up a backend section.

@ghost ghost assigned vojtajina Dec 21, 2013
@IgorMinar
Copy link
Contributor

punted from 1.2.8

@IgorMinar
Copy link
Contributor

related issue #5716

@caitp
Copy link
Contributor

caitp commented Jan 17, 2014

I have a patch which I believe addresses this at angular/angularjs.org#86 --- I am not totally able to test it, but it seems reasonable that that should fix it


edit: I guess my patch is unrelated to this issue, but fixes 5716... I can't actually reproduce the issue with the deep-linking example, though, the links are all target="_blank" and work as expected, far as I can tell. If this is the result of a recent fix, maybe we should close this issue?

@petebacondarwin
Copy link
Contributor

OK, here is the issue. If you click on the edit icon for one of the "JavaScript Projects" it correctly updates the URL and displays the edit form for that project. The trouble is that the docs app and the web server don't expect such URLs so if you navigate directly to such a URL as http://angularjs.org/edit/-JEKS-jn8XVQZ86IMXrU or you hit refresh when editing a project) you get a mess: the index.html mistakenly sets the base href to / and so all the CSS and javascript get messed up.

This may be fixable by creating a redirect on the server specifically for these "edit" URLs.

@petebacondarwin
Copy link
Contributor

And infact this will be fixed in the new docs as they will be run inside an iframe.

@petebacondarwin
Copy link
Contributor

Moved to bike-shed

@petebacondarwin
Copy link
Contributor

Actually we need to move this to angularjs.org repository since it is not specifically handled by the docs website right now. The good news is the using iframes in the docs, we can show that it works and is easy to fix. So we can update the angularjs.org main page at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants