Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

code examples: Removing text-shadow on the AngularJS bits will improve readability #16495

Closed
robwormald opened this issue Mar 19, 2018 · 2 comments

Comments

@robwormald
Copy link
Contributor

robwormald commented Mar 19, 2018

(moved from angular/angular#22855)

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[x ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

On https://angularjs.org, the styling on the AngularJS bits (tags, attributes, placeholders) in the code examples include a white colored text-shadow on a light blue background. This makes text difficult to read from 2-3ft (for example, a desktop monitor).

Expected behavior

The text doesn't need the white text-shadow. The light blue background is enough to identify it as AngularJS related.

Minimal reproduction of the problem with instructions

  1. Visit https://angularjs.org
  2. Scroll down to one of the code examples
    Screenshot

What is the motivation / use case for changing the behavior?

Changing will improve usability and possibly accessibility.

Environment

Chrome 65, Firefox 59, Ubuntu 16.04


Angular version: NA


Browser:
- [x ] Chrome (desktop) version 65
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x ] Firefox version 59
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: NA  
- Platform:  Linux

Others:

@gkalpak
Copy link
Member

gkalpak commented Mar 19, 2018

FWIW, neither looks very readable to me 😁
Maybe making the background lighter might help.

@frederikprijck
Copy link
Contributor

frederikprijck commented Mar 19, 2018

Apparently the fix needs to be done at https://github.com/angular/angularjs.org

I re-moved the moved issue and closed my PR 😕 🙈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants