Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

CSS animations not completed properly on Chrome 49 Canary and FF nightly #13496

Closed
majido opened this issue Dec 10, 2015 · 2 comments
Closed

Comments

@majido
Copy link

majido commented Dec 10, 2015

Context: There is an ongoing effect to change Event.timeStamp from epoch time to a high-res timestamp. This meas that Event.timeStamp is no longer going to be comparable to Date.now() due to different time origins but rather may be compared to performance.now(). This feature is currently enabled by default in Chrome 49 Canary (all platforms) and Firefox 44 developer edition (on certain platforms).

Issue: In angular, the logic for triggering animation completion for css animations depends on comparing Date.now() (i.e., startTime) with incoming animation event timestamp which is causing issues for certain types of animations (example.

Here is the original report on Firefox bugzilla which has some additional details.

Potential fix: A simple fix is to use Date.now() instead of event.timeStamp here. This is already the fallback option which is in fact being used for Firefox (FF has 0 for timestamp!). It should not have any really impact given that the current Event.timestamp is not much different from Date.now() when event handler is invoked.

@majido
Copy link
Author

majido commented Dec 10, 2015

/cc @matsko @Narretz

@petebacondarwin
Copy link
Contributor

Duplicate of #13494

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants