Potential issue in the documentation

[gcoutable]

Hi,

I was looking for some documentation about ngOption and I found this potential issue.

Here is a caution that warns us to do not use 'as' and 'track by' in the same expression :
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngOptions.js#L61

But the next example, uses 'as' and 'track by' in the same expression :
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngOptions.js#L67

Is that normal?

Regards,

Guillaume

[gkalpak]

@gcoutable, it's an "anti-example". It basically showcases what you shouldn't do and explains why it's not possible. In that sense, it's OK-ish.

Reading the explanation though, it seems that - while item.a as item.b for item in items track by item.c is not possible - using item as item.b for item in items track by item.c should be possible.

@petebacondarwin, should the documentation be updated (since the later is the most common usecase imo). I can't think of a good way to describe that when using track by and select as the select part should be the item itself.

[petebacondarwin]

The documentation should indeed be improved. I will take a look today as I am messing with ngOptions anyway.

[petebacondarwin]

I don't have time to do this. Would anyone else like to provide a PR?

[ryanhart2]

I submitted pull request #13000 to address this.

[Narretz]

The PR has been merged IIRC