Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Add MapFilter to help with iterating over maps. #931

Closed
wants to merge 1 commit into from
Closed

Add MapFilter to help with iterating over maps. #931

wants to merge 1 commit into from

Conversation

mvuksano
Copy link
Contributor

No description provided.

@mvuksano mvuksano added cla: yes and removed cla: no labels Apr 18, 2014
vicb
vicb reviewed Apr 19, 2014
View reviewed changes
lib/formatter/map.dart
List<_KeyValue<K, V>> call(Map<K, V> inputMap) {
if (inputMap == null) return null;
List<_KeyValue<K, V>> result = [];
inputMap.keys.forEach((K k) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the .keys here. Then the closure args are k, v.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vicb
Copy link
Contributor

vicb commented Apr 19, 2014

IMO "map" is not a great name for this formatter.

What about items or mapItems ? (Python uses items)

@mvuksano
Copy link
Contributor Author

Ok, I renamed to mapitems. I don't think items by itself is sufficient enough to communicate that this filter is only supposed to be used with maps.

@mvuksano
feat(MapFormatter): Add MapFormatter.
dae36eb 
MapFormatter can be used with repeat decorator to display a list of key value pairs

Closes dart-archive#394
mvuksano added a commit that referenced this pull request Apr 21, 2014
@mvuksano @mhevery
feat(formatter): Add arrayify formatter.
29c6b81 
MapFormatter can be used with map and ng-repeat to display a list of key value pairs

Closes #394

Closes #931
@mvuksano mvuksano closed this in d2780f8 Apr 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvuksano @vicb