This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Recording backend url #872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y installing extended PlaybackHttpBackendConfig class in applications.
| @@ -12,6 +12,9 @@ import 'package:angular/playback/playback_data.dart' as playback_data; | |||
|
|
|||
| @NgInjectableService() | |||
| class PlaybackHttpBackendConfig { | |||
|
|
|||
| String get recorder_url => '/record'; | |||
|
@kurman please squash the commits and follow the guidelines in CONTRIBUTING.md for the commit comment. Thanks. |
mhevery
pushed a commit
that referenced
this pull request
Apr 8, 2014
Moving hardcoded recorder URL to config class and can be overridden by installing extended PlaybackHttpBackendConfig class in applications. Closes #872
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Apr 9, 2014
Moving hardcoded recorder URL to config class and can be overridden by installing extended PlaybackHttpBackendConfig class in applications. Closes dart-archive#872
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving '/record' url to PlaybackHttpBackendConfig, should make overriding the value from app code easier.