Fixed null pointer bug in _revertToPreviousState #1691
Conversation
If i==0 (didn't go through the loop at all), prev would be null and prev._next would result in a null pointer exception.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Just submitted the CLA. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Added the correct email address to the CLA. |
|
CLAs look good, thanks! |
|
Can you add a test that reproduces this bug? |
If i==0 (didn't go through the loop at all), prev would be null and prev._next would result in a null pointer exception. Closes dart-archive#1691
If i==0 (didn't go through the loop at all), prev would be null and
prev._next would result in a null pointer exception.