This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(directive-injector): wrong variable name in error thrown. #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper type annotation that would have caught the typo.
|
There must be a test for this |
|
It is not obvious, but the "test" is adding the type to the error constructor. That caused the analyzer to fail. Fixing the variable name caused the analyzer to pass. |
|
Yey, optional typing :) |
rkirov
added a commit
that referenced
this pull request
Aug 29, 2014
Add proper type annotation that would have caught the typo. Closes #1397
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper type annotation that would have caught the typo.