fix(DynamicParser): Correctly handle throwing exceptions from method.

Fixes #971 Closes #1064
dart-archive · Jul 24, 2014 · 82ca6ba · 82ca6ba
1 parent 7677453
commit 82ca6ba
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/bin/parser_generator_for_spec.dart b/bin/parser_generator_for_spec.dart
@@ -100,6 +100,8 @@ main(arguments) {
       'map["square"] = 6',
       'method',
       'method()',
+      'causeException',
+      'causeException()',
       'notAFn()',
       'notmixed',
       'obj[0].name=1',

diff --git a/lib/core/parser/parser_dynamic.dart b/lib/core/parser/parser_dynamic.dart
@@ -45,11 +45,7 @@ class DynamicClosureMap implements ClosureMap {
           throw "Property '$name' is not of type function.";
         }
       } else {
-        try {
-          return reflect(o).invoke(symbol, posArgs, sNamedArgs).reflectee;
-        } on NoSuchMethodError catch (e) {
-          throw 'Undefined function or exception in $name $e';
-        }
+        return reflect(o).invoke(symbol, posArgs, sNamedArgs).reflectee;
       }
     };
   }

diff --git a/test/core/parser/parser_spec.dart b/test/core/parser/parser_spec.dart
@@ -10,6 +10,7 @@ class TestData {
   set str(x) => _str = x;
 
   method() => "testMethod";
+  causeException() => this.x();
   sub1(a, {b: 0}) => a - b;
   sub2({a: 0, b: 0}) => a - b;
 }
@@ -446,6 +447,12 @@ main() {
         expect(context['obj'].field['key']).toEqual(4);
       });
 
+      it('should rethrow an error from a function', () {
+        expect(() {
+          parser("causeException()").eval(new TestData());
+        }).toThrow('NoSuchMethodError');
+      });
+
 
       xit('should throw a nice error for type mismatch', () {
         context['obj'] = new SetterObject();