fix(routing): ng-view now clears the template when route is deactivated

Closes #245
dart-archive · Oct 30, 2013 · 681e7dd · 681e7dd
1 parent 46093e1
commit 681e7dd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/routing/ng_view.dart b/lib/routing/ng_view.dart
@@ -93,7 +93,14 @@ class NgViewDirective implements NgDetachAware {
     locationService._unregisterPortal(this);
   }
 
-  _show(String templateUrl) {
+  _show(String templateUrl, Route route) {
+    assert(route.isActive);
+    var subscription;
+    subscription = route.onLeave.listen((_) {
+      subscription.cancel();
+      _cleanUp();
+      _prevTemplateUrl = null;
+    });
     if (_prevTemplateUrl == templateUrl) return;
     _prevTemplateUrl = templateUrl;
 

diff --git a/lib/routing/routing.dart b/lib/routing/routing.dart
@@ -66,7 +66,7 @@ class _RoutingHelper {
             _routePath(route).startsWith(_routePath(v.route));
       }, orElse: () => null);
       if (view != null && !alreadyActiveViews.contains(view)) {
-        view._show(templateUrl);
+        view._show(templateUrl, route);
         alreadyActiveViews.add(view);
         break;
       }