perf(util): call toLowerCase() only where needed

Closes #1468
dart-archive · Sep 22, 2014 · 2bcd29e · 2bcd29e
1 parent 26df7c2
commit 2bcd29e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/utils.dart b/lib/utils.dart
@@ -82,9 +82,8 @@ relaxFnArgs(Function fn) {
 capitalize(String s) => s.substring(0, 1).toUpperCase() + s.substring(1);
 
 String camelCase(String s) {
-  var part = s.split('-').map((s) => s.toLowerCase());
-  if (part.length <= 1) return part.join();
-  return part.first + part.skip(1).map(capitalize).join();
+  var parts = s.split('-');
+  return parts.first.toLowerCase() + parts.skip(1).map(capitalize).join();
 }
 
 /// Returns whether or not the given identifier is a reserved word in Dart.

diff --git a/test/utils_spec.dart b/test/utils_spec.dart
@@ -44,6 +44,10 @@ main() {
     it('should lowercase strings', () {
       expect(camelCase('Caps-first')).toEqual('capsFirst');
     });
+
+    it('should work on empty string', () {
+      expect(camelCase('')).toEqual('');
+    });
   });
 }