Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): correctly respond to preflight requests #23642

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

alan-agius4
Copy link
Collaborator

With this commit, we add a middleware that handles preflight requests as currently responses for this type of requests returning 404.

This is a temporary workaround until this issue is fixed upstream. See: webpack/webpack-dev-server#4180

Closes #23639

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 27, 2022
@alan-agius4 alan-agius4 requested a review from clydin July 27, 2022 08:01
@alan-agius4 alan-agius4 force-pushed the option-request-handler branch from 70a3517 to b9548f1 Compare July 27, 2022 08:13
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just two typos.

…quests

With this commit, we add a middleware that handles preflight requests as currently responses for this type of requests returning 404.

This is a temporary workaround until this issue is fixed upstream. See: webpack/webpack-dev-server#4180

Closes angular#23639
@alan-agius4 alan-agius4 force-pushed the option-request-handler branch from b9548f1 to 732c9df Compare August 2, 2022 15:47
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 2, 2022
@dgp1130 dgp1130 merged commit b4a1b0f into angular:main Aug 2, 2022
@alan-agius4 alan-agius4 deleted the option-request-handler branch August 2, 2022 16:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS pre-flight requests return HTTP 404 on assets served by dev-server
3 participants