Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code shows lint errors for getters and setters: "Accessors are only available when targeting ECMAScript 5 and higher" for new RC.0 projects #5059

Closed
ogix opened this issue Feb 27, 2017 · 3 comments
Assignees

Comments

@ogix
Copy link

ogix commented Feb 27, 2017

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 10

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
@angular/cli: 1.0.0-rc.0
node: 6.10.0
os: win32 x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

  1. ng new test-app (Angular CLI RC.0)
  2. Open with VS Code
  3. Add getter/setter inside app component

The log given by the failure.

Normally this include a stack trace and some more information.
Shows lint error: "Accessors are only available when targeting ECMAScript 5 and higher"

Mention any other details that might be useful.


Thanks! We'll be in touch soon.

@ogix ogix changed the title VS Code shows lint errors for getters and setters: "Accessors are only available when targeting ECMAScript 5 and higher" VS Code shows lint errors for getters and setters: "Accessors are only available when targeting ECMAScript 5 and higher" for new RC.0 projects Feb 27, 2017
@ogix
Copy link
Author

ogix commented Feb 27, 2017

Actually only adding "target": "es5" at root tsconfig.json helped. I wonder if it is the only solution.

@sumitarora
Copy link
Contributor

Added "target": "es5" to tsconfig by default #5060

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants