fix(eject): start webpack-dev-server with e2e & sync its port with protractor default config port #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the 2nd and last thing that's needed for e2e to work in ejected projects. The first thing was the webdriver update, which is now merged in master already. |
…otractor default config port
filipesilva
approved these changes
Mar 1, 2017
filipesilva
pushed a commit
that referenced
this pull request
Mar 3, 2017
…with protractor default config port Close #4957
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
Start webpack-dev-server with e2e & sync its port with protractor default config port. Close angular#4957
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only handles default port for now as we don't seem to change protractor config in
eject.In the future we can provide something that takes the default
servetask port or the.angular-cli.jsonoverride default, but for now, this should do.It also starts the dev server with e2e by default because that's what the current version of the CLI does for non-ejected projects. It uses a
pre``prescript for that, which is a bit weird, but it gives the app more time to compile etc.