Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.nvmrc): change Node.js version from 4 to 6 #4399

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Feb 3, 2017

.nvmrc was still pointing to Node.js 4 even though CLI will soon require 6.9 or
newer.

@johnpapa
Copy link
Contributor

johnpapa commented Feb 3, 2017

Can this do minors? or just majors?

@mgol
Copy link
Member Author

mgol commented Feb 3, 2017

It can do minors (and patches) as well but if you e.g. only have 4.7.3, 6.9.5 & 7.5.0 installed and .nvmrc would point to 4.6 then nvm use will not change the version and you'd be left with the previous one, 7.5.0 on my machine.

I know Angular uses a full version but I don't see a lot of gain in that while I see losses.

.nvmrc was still pointing to Node.js 4 even though CLI will soon require 6.9 or
newer.
@mgol
Copy link
Member Author

mgol commented Feb 6, 2017

Is anything blocking this PR?

A discussion about whether to move to specify minors/patchers in .nvmrc can be led separately, this PR changes one major to another major and the current one is incorrect so it's a good change anyway. :)

@hansl hansl merged commit e6422e9 into angular:master Feb 7, 2017
@mgol mgol deleted the nvmrc branch February 7, 2017 09:11
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
.nvmrc was still pointing to Node.js 4 even though CLI will soon require 6.9 or
newer.
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
.nvmrc was still pointing to Node.js 4 even though CLI will soon require 6.9 or
newer.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants