Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser does not refresh after code changed #4329

Closed
web-dave opened this issue Feb 1, 2017 · 21 comments · Fixed by #4334
Closed

Browser does not refresh after code changed #4329

web-dave opened this issue Feb 1, 2017 · 21 comments · Fixed by #4334

Comments

@web-dave
Copy link

web-dave commented Feb 1, 2017

angular-cli: 1.0.0-beta.28.3
node: 6.9.2
os: win32 x64
@angular/common: 2.4.5
@angular/compiler: 2.4.5
@angular/core: 2.4.5
@angular/forms: 2.4.5
@angular/http: 2.4.5
@angular/platform-browser: 2.4.5
@angular/platform-browser-dynamic: 2.4.5
@angular/router: 3.4.5
@angular/compiler-cli: 2.4.5

ng serve
code change
webpack: Compiling... Hash: 228604d16756d5a0fdd3 Time: 717ms chunk {0} polyfills.bundle.js, polyfills.bundle.map (polyfills) 222 kB {4} [initial] chunk {1} main.bundle.js, main.bundle.map (main) 3.97 kB {3} [initial] chunk {2} styles.bundle.js, styles.bundle.map (styles) 10 kB {4} [initial] chunk {3} vendor.bundle.js, vendor.bundle.map (vendor) 2.64 MB [initial] chunk {4} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry] webpack: Compiled successfully.

browser don't refresh. do not solve the problem
rerun ng serve => change available

@trevor-hackett
Copy link

trevor-hackett commented Feb 1, 2017

That's weird I just created a new project with 1.0.0-beta.28.3 and it is refreshing just fine.

@web-dave
Copy link
Author

web-dave commented Feb 1, 2017

Yes. I just did a npm i -g angular-cli and ng new bla

@web-dave
Copy link
Author

web-dave commented Feb 1, 2017

I double checked it already

And I restarted my machine

@trevor-hackett
Copy link

trevor-hackett commented Feb 1, 2017

I can confirm. When editing the typescript it doesn't refresh. If you update the template, it refreshes.

@web-dave
Copy link
Author

web-dave commented Feb 1, 2017

I just unistalled it and reinstall it so I'll go back to previous, have to do a workshop tomorrow and need cli :(

@trevor-hackett
Copy link

trevor-hackett commented Feb 1, 2017

Looks like the typescript isn't getting compiled. I edit the typescript (introduce a function) and adjusted the template so that it would refresh. The new function doesn't get called (when clicking on a button to trigger the method) after the page refresh.

Instead get an error saying that the function doesn't exist.

Stopping ng serve and restarting it will recompile the typescript and suddenly the function exists.

@joshorvis
Copy link

Same issue here. I just tried uninstalling/reinstalling everything and running ng update, no change. Still seeing old .ts code until I stop and restart ng serve

@beeman
Copy link
Contributor

beeman commented Feb 1, 2017

Can you try npm install --save @ngtools/[email protected] to see if that fixes the issue?

@web-dave
Copy link
Author

web-dave commented Feb 1, 2017

Thx, that's it.

@joshorvis
Copy link

@beeman - that worked for me too, thanks!

@web-dave
Copy link
Author

web-dave commented Feb 2, 2017

I have the same issue with beta 29. This time it doesn't solve to install ngtools/webpack

@nisserne
Copy link

A late comment from a newbie.

Using Angular 4.0.2, it seems that the 'rebuild on change' does not work if the project path contains '('. Potentially other legal characters could also have this impact.

@adrianolsk
Copy link

I am facing the same problem now.
@angular/cli: 1.2.0
It detect the changes on .ts and html files, it says that it's compiling, the browser refreshes but nothing change. I can delete everything from many .ts files and it don't even show an error. Only way to see the changes is stopping and ng serve again

@p10tyr
Copy link

p10tyr commented May 23, 2018

I have noticed this on VS2017 15.7.1 ,dotnet core 2.1 and Angular/Angular-CLI ^6.0.3

(I removed webpack from packages completely - The angular add new does not use it so I nuked it too based on the dotnet core 2 template based on angular 5 (not the dot net core 1 template based on angualr 4))

  • It was not refreshing my page from VS but when I did a ng serve it worked as expected.
  • I noticed in VS that even on refreshing and I made changes they did not appear.
  • I looked in the output for ASP.NET Core Web Server
    • ** Angular Live Development Server is listening on localhost:50273, open your browser on http://localhost:50273/ **
    • This WAS not the port VS studio opened for me
    • When I went to this PORT it was changing fine

I realised it was serving an old build for some reason. Where does dotnet core serve build from? the /dist directory obviously.
I deleted everything in the /dist directory.
Refreshed the page on the port VS gave me and bam! It started working again with auto rebuild and auto refresh.

I think if something is in the dist folder then dotnet will NOT proxy to the CLI server. Make sure its clean

@kilanny
Copy link

kilanny commented Aug 16, 2018

@ppumkin I have this issue too. This needs to be reported to Microsoft.

@apoblock
Copy link

@ibraheemalkilanny Turning on the "Disable cache (while DevTools is open)" setting in the Chrome Developer Tools (F12 to open Dev Tools, then F1 to open settings page) resolved the issue for me.

@Hypenate
Copy link

Hypenate commented Aug 22, 2018

I was having the same issue, I resolved my issue by:

  • Updating all NuGet packages (I was running things in Visual Studio).

  • Updating all packages via ng update --all (that is if you are lucky), I had to update the core first and then find my way trough the rest.

  • Then I do a ng build --prod because some issues are only discovered then.

  • Then an ng serve (I think this is not necessary)

  • Delete the files from the dist folder

@rodrigoporcionato
Copy link

I have noticed this on VS2017 15.7.1 ,dotnet core 2.1 and Angular/Angular-CLI ^6.0.3

(I removed webpack from packages completely - The angular add new does not use it so I nuked it too based on the dotnet core 2 template based on angular 5 (not the dot net core 1 template based on angualr 4))

  • It was not refreshing my page from VS but when I did a ng serve it worked as expected.
  • I noticed in VS that even on refreshing and I made changes they did not appear.
  • I looked in the output for ASP.NET Core Web Server
    • ** Angular Live Development Server is listening on localhost:50273, open your browser on http://localhost:50273/ **
    • This WAS not the port VS studio opened for me
    • When I went to this PORT it was changing fine

I realised it was serving an old build for some reason. Where does dotnet core serve build from? the /dist directory obviously.
I deleted everything in the /dist directory.
Refreshed the page on the port VS gave me and bam! It started working again with auto rebuild and auto refresh.

I think if something is in the dist folder then dotnet will NOT proxy to the CLI server. Make sure its clean

Hi, This workaround worked perfecte for me!

@id1945
Copy link

id1945 commented Nov 7, 2018

I have this issue too.

@svassr
Copy link

svassr commented May 16, 2019

For me it's when I edit component styles (*.scss) that it won't refresh.
@angular/cli": "^7.3.9
@ngtools/[email protected]

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.