feat(build): add support for webpack stats JSON output #4189

winkerVSbecks · 2017-01-24T03:50:50Z

related to #3179

Allows you to run ng build --json which generates dist/stats.json. This can then be used with things like the webpack-bundle-analyzer or https://webpack.github.io/analyse/

googlebot · 2017-01-24T03:50:52Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

winkerVSbecks · 2017-01-24T03:52:21Z

I signed it!

googlebot · 2017-01-24T03:52:22Z

CLAs look good, thanks!

filipesilva · 2017-01-24T11:43:25Z

@hansl WDYT? See also #3179 for context.

I'm fine with the implementation myself.

clydin · 2017-01-24T19:32:05Z

Writing to stdout would be useful for automation purposes. other output would need to be disabled though.

If not, then being able to specify the output file would also be useful.

winkerVSbecks · 2017-01-24T19:52:24Z

@clydin I'm ok with that. I could add something like this:

--stats --json save stats.json
--stats --log would log to stdout

I'll let @filipesilva @hansl decide if that is something they want to support.

blaugold · 2017-02-02T17:47:08Z

packages/angular-cli/tasks/build.ts

+          const jsonStats = stats.toJson('verbose');
+
+          fs.writeFileSync(
+            path.resolve(project.root, outputDir, 'stats.json'),


@winkerVSbecks I think outputDir should be outputPath. There is no variable outputDir. That's what the compiler complains about and why the tests fail in ci.

winkerVSbecks · 2017-02-07T18:14:26Z

@hansl @blaugold updated to account for changes

filipesilva

Can you also add this flag to https://github.com/angular/angular-cli/blob/master/docs/documentation/build.md?

filipesilva · 2017-02-14T17:47:04Z

packages/@angular/cli/commands/build.ts

 ];

 export interface BuildTaskOptions extends BuildOptions {
  watch?: boolean;
+  watcher?: string;
+  supressSizes: boolean;


Can you remove these changes? They're redundant and should be obtained from BuildOptions.

winkerVSbecks · 2017-02-15T12:19:40Z

@filipesilva done

filipesilva · 2017-02-15T14:09:27Z

@winkerVSbecks I don't see the changes in, the interface still has all the duplicated members.

filipesilva · 2017-02-15T14:10:03Z

packages/@angular/cli/commands/build.ts

 ];

 export interface BuildTaskOptions extends BuildOptions {
  watch?: boolean;
+  baseHref?: string;


This should be only

export interface BuildTaskOptions extends BuildOptions { watch?: boolean; statsJson?: boolean; }

sorry, I misunderstood that.

filipesilva · 2017-02-15T14:10:07Z

docs/documentation/build.md

@@ -94,3 +94,5 @@ or `ng serve --prod` will also make use of uglifying and tree-shaking functional
 `--extract-css` (`-ec`) extract css from global styles onto css files instead of js ones

 `--output-hashing` define the output filename cache-busting hashing mode
+
+`--json` generates a `stats.json` file which can be analyzed using tools such as: `webpack-bundle-analyzer` or https://webpack.github.io/analyse


Can you change this to --stats-json?

filipesilva · 2017-02-15T14:41:31Z

packages/@angular/cli/commands/build.ts

@@ -31,10 +31,12 @@ export const baseBuildCommandOptions: any = [
    description: 'define the output filename cache-busting hashing mode',
    aliases: ['oh']
  },
+  { name: 'statsJson', type: Boolean, default: false },


The weird CI errors are due to this:

kamik@T460p MINGW64 /d/sandbox/master-project (master) $ ng build The "statsJson" option's name of the "build" command contains a capital letter. Error: The "statsJson" option's name of the "build" command contains a capital letter. at Class.Command.validateOption (D:\work\angular-cli\packages\@angular\cli\ember-cli\lib\models\command.js:238:11)

If you change it to stats-json it should be fine.

filipesilva · 2017-02-15T14:52:23Z

Thanks for implementing this and going through all the change requests!

Allows you to run ng build --json which generates dist/stats.json. This can then be used with things like the webpack-bundle-analyzer or https://webpack.github.io/analyse/ Fix angular#3179

angular-automatic-lock-bot · 2019-09-11T20:42:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Jan 24, 2017

googlebot added cla: yes and removed cla: no labels Jan 24, 2017

winkerVSbecks force-pushed the feat-webpack-json branch from 82b1eac to a5c18ad Compare January 24, 2017 03:53

filipesilva requested a review from hansl January 24, 2017 11:42

filipesilva added the pr_action: review label Jan 24, 2017

winkerVSbecks force-pushed the feat-webpack-json branch from a5c18ad to c476f9f Compare January 25, 2017 02:10

hansl removed the pr_action: review label Jan 27, 2017

blaugold reviewed Feb 2, 2017

View reviewed changes

winkerVSbecks force-pushed the feat-webpack-json branch 3 times, most recently from d1df040 to 7a55eb7 Compare February 7, 2017 16:58

winkerVSbecks force-pushed the feat-webpack-json branch 6 times, most recently from dbf5f2a to c97a0db Compare February 13, 2017 15:53

filipesilva suggested changes Feb 14, 2017

View reviewed changes

winkerVSbecks force-pushed the feat-webpack-json branch from c97a0db to 3b07927 Compare February 15, 2017 02:03

filipesilva suggested changes Feb 15, 2017

View reviewed changes

winkerVSbecks force-pushed the feat-webpack-json branch from 3b07927 to c4fca3d Compare February 15, 2017 14:22

filipesilva suggested changes Feb 15, 2017

View reviewed changes

Added support for webpack stats JSON output

71bc1ac

winkerVSbecks force-pushed the feat-webpack-json branch from c4fca3d to 71bc1ac Compare February 15, 2017 14:51

filipesilva approved these changes Feb 15, 2017

View reviewed changes

filipesilva merged commit 469ca91 into angular:master Feb 15, 2017

winkerVSbecks deleted the feat-webpack-json branch February 15, 2017 15:40

filipesilva mentioned this pull request Feb 16, 2017

refactor(@angular/cli): move stats-json to build only #4746

Merged

m98 mentioned this pull request Sep 5, 2017

feature: upgrade to use @angular/cli angular/universal-starter#418

Merged

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(build): add support for webpack stats JSON output #4189

feat(build): add support for webpack stats JSON output #4189

winkerVSbecks commented Jan 24, 2017 •

edited

Loading

googlebot commented Jan 24, 2017

winkerVSbecks commented Jan 24, 2017

googlebot commented Jan 24, 2017

filipesilva commented Jan 24, 2017

clydin commented Jan 24, 2017 •

edited

Loading

winkerVSbecks commented Jan 24, 2017 •

edited

Loading

blaugold Feb 2, 2017

winkerVSbecks commented Feb 7, 2017

filipesilva left a comment

filipesilva Feb 14, 2017

winkerVSbecks commented Feb 15, 2017

filipesilva commented Feb 15, 2017

filipesilva Feb 15, 2017

winkerVSbecks Feb 15, 2017

filipesilva Feb 15, 2017

filipesilva Feb 15, 2017

filipesilva commented Feb 15, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

feat(build): add support for webpack stats JSON output #4189

feat(build): add support for webpack stats JSON output #4189

Conversation

winkerVSbecks commented Jan 24, 2017 • edited Loading

googlebot commented Jan 24, 2017

winkerVSbecks commented Jan 24, 2017

googlebot commented Jan 24, 2017

filipesilva commented Jan 24, 2017

clydin commented Jan 24, 2017 • edited Loading

winkerVSbecks commented Jan 24, 2017 • edited Loading

blaugold Feb 2, 2017

Choose a reason for hiding this comment

winkerVSbecks commented Feb 7, 2017

filipesilva left a comment

Choose a reason for hiding this comment

filipesilva Feb 14, 2017

Choose a reason for hiding this comment

winkerVSbecks commented Feb 15, 2017

filipesilva commented Feb 15, 2017

filipesilva Feb 15, 2017

Choose a reason for hiding this comment

winkerVSbecks Feb 15, 2017

Choose a reason for hiding this comment

filipesilva Feb 15, 2017

Choose a reason for hiding this comment

filipesilva Feb 15, 2017

Choose a reason for hiding this comment

filipesilva commented Feb 15, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

winkerVSbecks commented Jan 24, 2017 •

edited

Loading

clydin commented Jan 24, 2017 •

edited

Loading

winkerVSbecks commented Jan 24, 2017 •

edited

Loading