Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json-schema): Introduce a separate package for JSON schema. #3927

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Jan 10, 2017

This is the same code we used before, but:

  1. its in a separate package,
  2. it also support new serialization to .d.ts,
  3. OneOf is now supported entirely (instead of the previous hack).

Also, removed the schema.d.ts file and generate it before building the package. It is not git ignored and changing it will not work (it will be overwritten).

@hansl hansl force-pushed the schema-tests-2 branch 4 times, most recently from 7aa3473 to ccb7997 Compare January 10, 2017 20:13
This is the same code we used before, but:
1. its in a separate package,
2. it also support new serialization to .d.ts,
3. OneOf is now supported entirely (instead of the previous hack).

Also, removed the schema.d.ts file and generate it before building the package. It is not git ignored and changing it will not work (it will be overwritten).
@hansl hansl merged commit 74f7cdd into angular:master Jan 11, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…ema. (angular#3927)

This is the same code we used before, but:

1. its in a separate package,
2. it also support new serialization to .d.ts,
3. OneOf is now supported entirely (instead of the previous hack).

Also, removed the schema.d.ts file and generate it before building the package. It is not git ignored and changing it will not work (it will be overwritten).
@hansl hansl deleted the schema-tests-2 branch August 2, 2018 19:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants