Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Loading not creating bundles #2937

Closed
deebloo opened this issue Oct 28, 2016 · 12 comments
Closed

Lazy Loading not creating bundles #2937

deebloo opened this issue Oct 28, 2016 · 12 comments
Labels
needs: investigation Requires some digging to determine if action is needed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@deebloo
Copy link
Contributor

deebloo commented Oct 28, 2016

OS?

OSX El Capitan

Versions.

angular-cli: 1.0.0-beta.18
node: 6.7.0
os: darwin x64

Repro steps.

configure routing module and lazy load another module via route.
verify that two bundles are being created
Install a dependency from github. ex github:username/cool-module
Import module for that dependency into the root module.
verify that the one a SINGLE bundle is being created.

Mention any other details that might be useful.

I tried to be as detailed here as I could. When I have time I will create a public repo to reproduce if this is not sufficient.

@a5hik
Copy link

a5hik commented Oct 30, 2016

For me the Bundles for lazy load Routing modules are not getting created. It only creates a main chunk and not any module chunks.

@EmmanuelDemey
Copy link
Contributor

I have the same issue. I have updated my app to angular-cli beta18 (from beta16), and my extra chunks are not created anymore, but they are included inside the main bundle file.
Any ideas ?

@deebloo
Copy link
Contributor Author

deebloo commented Nov 1, 2016

I have been digging into it more. Still haven't identified an exact cause. I am trying to break it down to as small an example as I can. I looked through the cli code but I couldn't find anything that jumps our as a culprit. Will update issue when I find something.

@JiriBalcar
Copy link

Is this duplicate with #2496?

@filipesilva filipesilva added needs: investigation Requires some digging to determine if action is needed command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Nov 3, 2016
@ghost
Copy link

ghost commented Nov 3, 2016

I've got two projects, a new project (just started 2 weeks ago) and it's generating chunks. An older project, which is bigger, doesn't generate any chunks and I'm sure my lazy loading modules are not imported anywhere using import{} statement.

As a test, I've added an empty module to that project, lazy loading it from the root module, and still no chunks.

@a5hik
Copy link

a5hik commented Nov 5, 2016

For me the issue seems to be..

#2496 (comment)

@leonelgoncalves
Copy link

leonelgoncalves commented Nov 7, 2016

having the same issue here... when trying to lazy-load a module the CLI is not generating the bundle for that module. I'm using version 1.0.0-beta.19-3 of angular-cli

@a5hik
Copy link

a5hik commented Nov 9, 2016

@filipesilva Do you have any update on this? Or anyone found any workaround?

@VinayLeaf
Copy link

@filipesilva having same issue.

@serhiisol
Copy link
Contributor

@a5hik have you tried this workaround #2496 (comment) ?

@filipesilva
Copy link
Contributor

I'm sorry but I don't have an update, no. It's on the shortlist of stuff that needs to be looked into for RC1. I'm closing in favor of #2496 as it seems to be the same.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

No branches or pull requests

8 participants