Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon not copied to dist folder #2804

Closed
meeroslav opened this issue Oct 20, 2016 · 4 comments
Closed

Favicon not copied to dist folder #2804

meeroslav opened this issue Oct 20, 2016 · 4 comments

Comments

@meeroslav
Copy link

Favicon doesn't get copied to dist folder on production build.
Moving favicon.ico to assets folder solves the issue of course.
Potential solutions are to change blueprint and move file to assets by default or check why copying fails on --prod.

OS?

Windows 7 (others as well, but not tested)

Versions.

angular-cli: 1.0.0-beta.16
node: 5.10.1
os: win32 x64

Repro steps.

Run ng build --prod. Start the app from dist folder

The log given by the failure.

404 in browser for favicon.ico

@grizzm0
Copy link
Contributor

grizzm0 commented Oct 20, 2016

This has been fixed in #2570 and will be released with beta 18. This issue can be closed.

@Splaktar
Copy link
Member

beta.18 is out today and includes this fix! Just verified in my project.

@filipesilva
Copy link
Contributor

^ what @grizzm0 and @Splaktar just said 💃

It's worth mentioning that it works because assets now accepts an array, meaning if you have an existing projects and want favicon to be copied, you should add it to the array as shows in #2570.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants