Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular.json budgets not finding the created bundles #27936

Closed
kees-wiegel-visma opened this issue Jun 26, 2024 · 1 comment · Fixed by #27947
Closed

Angular.json budgets not finding the created bundles #27936

kees-wiegel-visma opened this issue Jun 26, 2024 · 1 comment · Fixed by #27947
Assignees

Comments

@kees-wiegel-visma
Copy link

Which @angular/* package(s) are the source of the bug?

compiler-cli

Is this a regression?

Yes

Description

We have a lot of different bundles defined in our project, and each of those bundles has budgets assigned. After updating to angular 18, this has stopped functioning properly.

package.json prerequisite:
"@fortawesome/fontawesome-pro": "^5.15.4",

angular.json bundle definition:

"styles": [
    {
      "input": "node_modules/@fortawesome/fontawesome-pro/css/all.min.css",
      "inject": false,
      "bundleName": "generic-fontawesome"
    }
]

angular.json budget definition:

"budgets": [
    {
        "type": "bundle",
        "name": "generic-fontawesome",
        "baseline": "170.10kB",
        "warning": "1kB",
        "error": "1kB"
    }
]

The file does get created:
dist\app\browser\generic-fontawesome.css
and has contents:
image

The related styling is also applied on the page where we want it (the contents not only exist but are correct).

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

▲ [WARNING] generic-fontawesome failed to meet minimum budget. Budget 173.16 kB was not met by 173.16 kB with a total of 0 bytes.
X [ERROR] generic-fontawesome failed to meet minimum budget. Budget 173.16 kB was not met by 173.16 kB with a total of 0 bytes.

Please provide the environment you discovered this bug in (run ng version)

Node: 18.20.3
Package Manager: npm 10.6.0
OS: win32 x64

Angular: 18.0.4
... animations, cdk, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1800.5
@angular-devkit/core         18.0.5
@angular-devkit/schematics   18.0.5
@angular/build               18.0.5
@angular/cli                 18.0.5
@schematics/angular          18.0.5
rxjs                         7.8.1
typescript                   5.4.5
zone.js                      0.14.7

Anything else?

No response

@alxhub alxhub transferred this issue from angular/angular Jun 26, 2024
@clydin clydin added needs: investigation Requires some digging to determine if action is needed area: @angular/build labels Jun 26, 2024
@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken and removed needs: investigation Requires some digging to determine if action is needed labels Jun 27, 2024
@alan-agius4 alan-agius4 self-assigned this Jun 27, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 27, 2024
…traints

This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: angular#27936
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 27, 2024
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: angular#27936
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 27, 2024
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: angular#27936
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 27, 2024
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: angular#27936
alan-agius4 added a commit that referenced this issue Jun 27, 2024
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: #27936
(cherry picked from commit f3ba208)
alan-agius4 added a commit that referenced this issue Jun 27, 2024
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: #27936
(cherry picked from commit f3ba208)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants