Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): use config output path as default #2158

Merged
merged 2 commits into from
Sep 27, 2016
Merged

fix(build): use config output path as default #2158

merged 2 commits into from
Sep 27, 2016

Conversation

filipesilva
Copy link
Contributor

Fix #2006

hansl
hansl approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an e2e test for this?

@filipesilva filipesilva force-pushed the fix-config-output-path branch from a8db43a to 3d5263b Compare September 27, 2016 10:39
TheLarkInn
TheLarkInn approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@filipesilva filipesilva merged commit 49a120b into angular:master Sep 27, 2016
@filipesilva filipesilva deleted the fix-config-output-path branch September 27, 2016 16:23
@vkniazeu vkniazeu mentioned this pull request Sep 28, 2016
Closed
@filipesilva filipesilva mentioned this pull request Sep 30, 2016
Closed
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 2, 2016
@filipesilva
fix(build): use config output path as default (angular#2158)
32839bb
deebloo pushed a commit to deebloo/angular-cli that referenced this pull request Oct 3, 2016
@filipesilva
fix(build): use config output path as default (angular#2158)
13c6e98
@filipesilva filipesilva mentioned this pull request Oct 3, 2016
Closed
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 9, 2016
@filipesilva
fix(build): use outputPath from config
b39a09c 
Follow up from angular#2158
Fix angular#2511
@filipesilva filipesilva mentioned this pull request Oct 9, 2016
Closed
filipesilva added a commit that referenced this pull request Oct 10, 2016
@filipesilva
fix(build): use outputPath from config
ec0cdb5 
Follow up from #2158
Fix #2511
Close #2611
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
@filipesilva
fix(build): use outputPath from config
7ea6b6d 
Follow up from angular#2158
Fix angular#2511
Close angular#2611
Brocco pushed a commit that referenced this pull request Oct 19, 2016
@filipesilva @Brocco
fix(build): use outputPath from config
2f9dafe 
Follow up from #2158
Fix #2511
Close #2611
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
@filipesilva @Brocco
fix(build): use outputPath from config
9946c64 
Follow up from angular#2158
Fix angular#2511
Close angular#2611
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheLarkInn TheLarkInn TheLarkInn approved these changes

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to set outDir to "../www/"
4 participants
@filipesilva @hansl @TheLarkInn @googlebot