fix: removed travis-specific configuration from karma.conf.js

[andyskw]

The pull request removes the travis-specific custom launcher from karma.conf.js as per discussed in #1738.

Hopefully there will be a follow-up PR, allowing the user to successfully run their karma test cases in their CI tools, without having to change the karma.conf.js generated by angular-cli, but it still needs some investigations and decisions to be made about the approach.

[filipesilva]

Try removing this bit as well in ./tests/e2e/e2e_workflow.spec.js:

  // In travis CI only run tests in Chrome_travis_ci
  if (process.env.TRAVIS) {
    testArgs.push('--browsers');
    testArgs.push('Chrome_travis_ci');
  }

[andyskw]

I've updated it, moved the logic out to travis.yml - let's see if CI passes.

[filipesilva]

This line still needs to stay though. CI fails because it's missing, and it's what makes unit tests run in single run mode.

[hansl]

Rerunning OSX Node 5, travis is having problems with their OSX VMs.

[andyskw]

It's weird, it still fails on OSX, but looks like karma's chrome exits normally. Do you think it is caused by the PR, or is it just the OSX image?

[hansl]

The OSX VM are all timing out. https://www.traviscistatus.com/ says all builds are stopped.

Please rebase on top of master, I'll wait for linux and linting to pass and merge this. Thanks!

[andyskw]

After the rebase i've also added no sandbox to osx, maybe it fixes the issue.

[andyskw]

Rebased, and also edited the script in travis.yml, which adds --no-sandbox flag to chrome. With the new version in hand, the script creates the ~/.config directory explicitly. Now it seems to be stable.

[filipesilva]

It's in! Thanks so much for this @andyskw, I think I might use your technique the next time I setup travis on other repos. It's just really clean!

[andyskw]

I'm happy if it helped, thanks for the effort and for the merge!

On the other hand, the generated ng2 projects still wont work with CI-s, since karma's autowatch is enabled there. Karma will be able to start (with the proper CI config in hand), but it will never stop running.

If we could tell the karma config somehow dynamically, that the context is a CI environment, we could disable autowatch (or enable singleRun, doesn't matter) without having to make any changes in the generated project.

Do you think it worth the effort? If so, I'd be happy to give a PR, which waits for an environment variable (CONTEXT_CI maybe?), and based on the existence of that variable, it overrides the default karma configuration.

With that one, the angular 2 app developer only has to add an export CONTEXT_CI=true in the .travis.yml/teamcity build config/jenkins blabla..., and it just works.

What do you think?

[filipesilva]

I suppose that would work, but you can also do ng test --watch=false in the CI to run your tests, can't you? That's what we do in the CLI CI to get the generated project to run it's tests.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}