Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-js dependency not removed after updating to v8 #14636

Closed
markgoho opened this issue Jun 2, 2019 · 4 comments
Closed

core-js dependency not removed after updating to v8 #14636

markgoho opened this issue Jun 2, 2019 · 4 comments

Comments

@markgoho
Copy link
Contributor

markgoho commented Jun 2, 2019

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [X] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

No.

Description

Per #13954 (comment) - should the project dependency on core-js be removed when updating? It isn't present in new v8 projects.

🔬 Minimal Reproduction

Run ng update @angular/cli @angular/core on a v7 project. See that after the update, core-js is still listed as a dependency.

@destus90
Copy link
Contributor

destus90 commented Jun 3, 2019

I've upgraded my project some days ago and these polyfills were deleted from my polyfills.ts file.

import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/set';

@alan-agius4 alan-agius4 added this to the 8.0.x milestone Jun 3, 2019
@ngbot ngbot bot removed this from the 8.0.x milestone Jun 3, 2019
@alan-agius4 alan-agius4 added this to the 8.0.x milestone Jun 3, 2019
@ngbot ngbot bot removed this from the 8.0.x milestone Jun 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jun 3, 2019
@clydin
Copy link
Member

clydin commented Jun 3, 2019

Removing it requires an analysis of all application code to ensure it is not used as well as any dependencies which might have a peer dependency on the package. While possible it is also complex and potentially time-intensive for large projects.

@alan-agius4
Copy link
Collaborator

Closing as per above comment.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants