Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli commands (add, update) remove empty lines from package.json #12092

Closed
alexeagle opened this issue Sep 4, 2018 · 2 comments
Closed

cli commands (add, update) remove empty lines from package.json #12092

alexeagle opened this issue Sep 4, 2018 · 2 comments

Comments

@alexeagle
Copy link
Contributor

From @gkalpak on May 18, 2018 11:11

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Area

- [x] devkit
- [x] schematics

Versions

All

Repro steps

Some commands that modify package.json (e.g. ng update ... or ng add @angulatr/pwa (probably other ng add commands as well), remove an extra empty lines at the end of the file.

Desired functionality

Modifications in package.json should preserve empty lines. (Ideally, all whitespace should be preserved.)
Having an empty line at the end of each file is a common convention and removing such lines creates unnecessary noise in diffs. (Also note that other tools (e.g. yarn install) tend to add them back, which creates more unnecessary noise 😁)

Copied from original issue: angular/devkit#940

@alan-agius4
Copy link
Collaborator

Duplicate of #11744

@alan-agius4 alan-agius4 marked this as a duplicate of #11744 Oct 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants