feat: add utilities for typescript ast #1159

emma-mens · 2016-06-21T20:21:13Z

'ast-utils.ts' provides typescript ast utility functions

googlebot · 2016-06-22T16:31:57Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-06-27T17:05:14Z

CLAs look good, thanks!

googlebot · 2016-07-01T01:03:13Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-07-01T17:45:51Z

CLAs look good, thanks!

alxhub · 2016-07-06T17:01:36Z

addon/ng2/blueprints/routes/index.js

+  description: 'Generates a route/guard and template',
+
+  files: function(){
+    var fileList = getFiles.call(this);


You can rewrite this cleanly as:

return getFiles .call(this) .filter(...);

hansl · 2016-07-15T01:37:20Z

addon/ng2/utilities/ast-utils.ts

@@ -0,0 +1,53 @@
+import * as ts from 'typescript';
+import { InsertChange } from './change';
+/**


Nit: empty line before to separate.

hansl · 2016-07-15T01:38:05Z

Some nits but LGTM. @alxhub do you want to review too?

alxhub · 2016-07-18T18:30:08Z

addon/ng2/utilities/ast-utils.ts

+* @param kind (a valid index of ts.SyntaxKind enum, eg ts.SyntaxKind.ImportDeclaration)
+* @return all nodes of kind kind, or [] if none is found
+*/
+export function findNodes (node: ts.Node, kind: number, arr: ts.Node[] = []): ts.Node[] {


No space between function name and parameters.

The arr: ts.Node[] parameter here is a little messy. Since the function returns an array already, why not make it also allocate its own array and accumulate values into that?

hansl · 2016-07-18T21:59:15Z

addon/ng2/utilities/ast-utils.ts

+ * @throw Error if toInsert is first occurence but fall back is not set
+ */
+export function insertAfterLastOccurrence(nodes: ts.Node[], toInsert: string, file: string,
+                        fallbackPos?: number, syntaxKind?: ts.SyntaxKind): Change {


Left align either with the first argument or indented with 4 spaces please.

hansl · 2016-07-20T21:23:23Z

LGTM. @alxhub ?

hansl · 2016-07-22T17:01:15Z

@emma-mens: Can you rebase this on top of master? I can help you

'ast-utils.ts' provides typescript ast utility functions

* build: use webpack for building apps. This pull request replaces the underlying broccoli build system and then replaces it with webpack as the build and bundler. This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.): ng build (with --env flag and --watch flag supported) ng serve (with --port flag supported) ng test / ng e2e The webpack configuration is blackboxed, and therefore users will not see a webpack.config.js file in their repository. Also this PR will bump the typescript version to 2.0 (beta). Fixes #909 #1155 #882 * chore(lint) Corrected any eslint errors and cleaned up unused files * chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files. * chore: remove bind from serve command * chore: simplify test command * chore: fix test warnings * chore: revert whitespace changes * chore: re-add mapRoot to tsconfig * chore: remove unused import * bugfix: fix broken tests * fix: fix mobile-specific feature test * bugfix: fix public folder test * fix: fixes for path mappings, tests, and coverage (#1359) * fix(): Multiple fixes for path mappings: * Removed invalid test case that was throwing path mappings tests because of a typescript bug. * Readded PathsPlugin for Path Mappings * Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be. * Added sourcemap support for istanbul instrumenter. Coverage files are still being generated. * fix: fix the way the build command runs for mobile tests * fix: fix the way the build command runs for mobile tests * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: add environment configuration replacement (#1364) * fix: add environment configuration replacement * remove debuggers * fix: move mobile test above config test because it relies on prod build from previous step * fix: removed unneeded interface moved config paths * fix(tests): re-enable sass/less/stylus tests (#1363) * chore: remove systemjs (#1376) * chore: remove vendor.ts (#1383) * chore: remove material2 test option (#1385) * fix(build): re-add support for sourceDir (#1378) * chore(build): remove broccoli (#1386) * chore: remove windows elevation check (#1384) * fix(test): add missing sourceDir (#1387) * fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (#1395) * chore(tests): add prod env e2e test (#1394) * chore: cleanup of new files (#1388) * fix(serve): disable HMR (#1402) * chore: review docs (#1407) * feat(env): decouple build from env file (#1404) * fix: fix tsconfig for editors (#1420) * chore: fix webpack branch after merge conflicts (#1423) * fix: update to awesome-typescript-loader 2.1.0 (#1425) * fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json * fix: forgot to set libs in tsconfig blueprint * chore(blueprints): remove module.id (#1426) * feat: add host flag support for ng serve (#1442) * feat(test): add karma plugin (#1437) * chore(blueprints): re-add outDir (#1428) * feat: use @types instead of typings (#1449) * fix: make sourcemaps work in test (#1447) * feat: add utilities for typescript ast (#1159) (#1453) 'ast-utils.ts' provides typescript ast utility functions

'ast-utils.ts' provides typescript ast utility functions

* build: use webpack for building apps. This pull request replaces the underlying broccoli build system and then replaces it with webpack as the build and bundler. This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.): ng build (with --env flag and --watch flag supported) ng serve (with --port flag supported) ng test / ng e2e The webpack configuration is blackboxed, and therefore users will not see a webpack.config.js file in their repository. Also this PR will bump the typescript version to 2.0 (beta). Fixes angular#909 angular#1155 angular#882 * chore(lint) Corrected any eslint errors and cleaned up unused files * chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files. * chore: remove bind from serve command * chore: simplify test command * chore: fix test warnings * chore: revert whitespace changes * chore: re-add mapRoot to tsconfig * chore: remove unused import * bugfix: fix broken tests * fix: fix mobile-specific feature test * bugfix: fix public folder test * fix: fixes for path mappings, tests, and coverage (angular#1359) * fix(): Multiple fixes for path mappings: * Removed invalid test case that was throwing path mappings tests because of a typescript bug. * Readded PathsPlugin for Path Mappings * Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be. * Added sourcemap support for istanbul instrumenter. Coverage files are still being generated. * fix: fix the way the build command runs for mobile tests * fix: fix the way the build command runs for mobile tests * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: add environment configuration replacement (angular#1364) * fix: add environment configuration replacement * remove debuggers * fix: move mobile test above config test because it relies on prod build from previous step * fix: removed unneeded interface moved config paths * fix(tests): re-enable sass/less/stylus tests (angular#1363) * chore: remove systemjs (angular#1376) * chore: remove vendor.ts (angular#1383) * chore: remove material2 test option (angular#1385) * fix(build): re-add support for sourceDir (angular#1378) * chore(build): remove broccoli (angular#1386) * chore: remove windows elevation check (angular#1384) * fix(test): add missing sourceDir (angular#1387) * fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (angular#1395) * chore(tests): add prod env e2e test (angular#1394) * chore: cleanup of new files (angular#1388) * fix(serve): disable HMR (angular#1402) * chore: review docs (angular#1407) * feat(env): decouple build from env file (angular#1404) * fix: fix tsconfig for editors (angular#1420) * chore: fix webpack branch after merge conflicts (angular#1423) * fix: update to awesome-typescript-loader 2.1.0 (angular#1425) * fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json * fix: forgot to set libs in tsconfig blueprint * chore(blueprints): remove module.id (angular#1426) * feat: add host flag support for ng serve (angular#1442) * feat(test): add karma plugin (angular#1437) * chore(blueprints): re-add outDir (angular#1428) * feat: use @types instead of typings (angular#1449) * fix: make sourcemaps work in test (angular#1447) * feat: add utilities for typescript ast (angular#1159) (angular#1453) 'ast-utils.ts' provides typescript ast utility functions

angular-automatic-lock-bot · 2019-09-10T01:42:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jun 21, 2016

emma-mens force-pushed the ast-utils branch 2 times, most recently from b9f77dc to 2802d4d Compare June 22, 2016 16:31

googlebot added cla: no and removed cla: yes labels Jun 22, 2016

emma-mens force-pushed the ast-utils branch 2 times, most recently from bfc6260 to cf2d9d6 Compare June 27, 2016 17:05

googlebot added cla: yes and removed cla: no labels Jun 27, 2016

emma-mens force-pushed the ast-utils branch 3 times, most recently from 831fe06 to fda7fbd Compare July 1, 2016 01:03

googlebot added cla: no and removed cla: yes labels Jul 1, 2016

emma-mens force-pushed the ast-utils branch 2 times, most recently from c8612c0 to 73a278d Compare July 1, 2016 17:45

googlebot added cla: yes and removed cla: no labels Jul 1, 2016

emma-mens force-pushed the ast-utils branch 2 times, most recently from 8d2b180 to d4d15aa Compare July 1, 2016 22:12

alxhub reviewed Jul 6, 2016
View reviewed changes

emma-mens force-pushed the ast-utils branch 3 times, most recently from 46c965c to ab82133 Compare July 14, 2016 22:57

hansl reviewed Jul 15, 2016
View reviewed changes

emma-mens force-pushed the ast-utils branch from ab82133 to f20747a Compare July 18, 2016 17:24

alxhub reviewed Jul 18, 2016
View reviewed changes

emma-mens force-pushed the ast-utils branch 2 times, most recently from 131e58d to 81a193d Compare July 18, 2016 21:29

hansl reviewed Jul 18, 2016
View reviewed changes

emma-mens force-pushed the ast-utils branch from 81a193d to 1e23902 Compare July 19, 2016 00:25

feat: add utilities for typescript ast

4d7cf14

'ast-utils.ts' provides typescript ast utility functions

emma-mens force-pushed the ast-utils branch from 1e23902 to 4d7cf14 Compare July 22, 2016 22:02

hansl merged commit 0cfc2bf into angular:master Jul 22, 2016

emma-mens deleted the ast-utils branch July 22, 2016 23:18

hansl added a commit that referenced this pull request Jul 26, 2016

feat: add utilities for typescript ast (#1159) (#1453)

a3b1bf4

'ast-utils.ts' provides typescript ast utility functions

Splaktar pushed a commit to DevIntent/angular-cli that referenced this pull request Jul 31, 2016

feat: add utilities for typescript ast (angular#1159)

908c5a2

'ast-utils.ts' provides typescript ast utility functions

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add utilities for typescript ast #1159

feat: add utilities for typescript ast #1159

emma-mens commented Jun 21, 2016 •

edited

Loading

googlebot commented Jun 22, 2016

googlebot commented Jun 27, 2016

googlebot commented Jul 1, 2016

googlebot commented Jul 1, 2016

alxhub Jul 6, 2016

hansl Jul 15, 2016 •

edited

Loading

hansl commented Jul 15, 2016 •

edited

Loading

alxhub Jul 18, 2016

alxhub Jul 18, 2016

hansl Jul 18, 2016

hansl commented Jul 20, 2016

hansl commented Jul 22, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

feat: add utilities for typescript ast #1159

feat: add utilities for typescript ast #1159

Conversation

emma-mens commented Jun 21, 2016 • edited Loading

googlebot commented Jun 22, 2016

googlebot commented Jun 27, 2016

googlebot commented Jul 1, 2016

googlebot commented Jul 1, 2016

alxhub Jul 6, 2016

Choose a reason for hiding this comment

hansl Jul 15, 2016 • edited Loading

Choose a reason for hiding this comment

hansl commented Jul 15, 2016 • edited Loading

alxhub Jul 18, 2016

Choose a reason for hiding this comment

alxhub Jul 18, 2016

Choose a reason for hiding this comment

hansl Jul 18, 2016

Choose a reason for hiding this comment

hansl commented Jul 20, 2016

hansl commented Jul 22, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

emma-mens commented Jun 21, 2016 •

edited

Loading

hansl Jul 15, 2016 •

edited

Loading

hansl commented Jul 15, 2016 •

edited

Loading