Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use !important for css vars #10221

Closed
MurhafSousli opened this issue Apr 7, 2018 · 2 comments
Closed

Can't use !important for css vars #10221

MurhafSousli opened this issue Apr 7, 2018 · 2 comments

Comments

@MurhafSousli
Copy link

MurhafSousli commented Apr 7, 2018

Versions

cli: 1.7.3

Repro steps

.test {
  --button-color: #FF6651 !important;
}

Observed behavior

Build fails

ERROR in ./node_modules/raw-loader!./node_modules/postcss-loader/lib??embedded!./node_modules/sass-loader/lib/loader.js??ref--8-3!./src/styles.scss Module build failed: --button-color: #FF6651 !important; ^ Invalid CSS after "...-color: #FF6651": expected "}", was "!important;"

Desired behavior

Should compile

Mention any other details that might be useful (optional)

Related sass/libsass#2590

It seems that they have fixed it, but maybe the cli should update to their new version

@clydin
Copy link
Member

clydin commented Apr 7, 2018

The CLI uses "node-sass": "^4.7.2" for the sass dependency. Once node-sass catches up to lib sass with the bug fix, the CLI will automatically be able to use that version.

@clydin clydin closed this as completed Apr 7, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants