From 77355169497d6fd570041bb7bf4494fff212a7fb Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Thu, 7 Nov 2019 13:37:12 -0500 Subject: [PATCH] fix(@angular/cli): disable update commit creation by default Closes #16013 --- packages/angular/cli/commands/update-impl.ts | 6 +++--- packages/angular/cli/commands/update.json | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/angular/cli/commands/update-impl.ts b/packages/angular/cli/commands/update-impl.ts index 5d84e1ae5a5e..a15e334bda5d 100644 --- a/packages/angular/cli/commands/update-impl.ts +++ b/packages/angular/cli/commands/update-impl.ts @@ -425,7 +425,7 @@ export class UpdateCommand extends Command { packageName, migrations, migrationRange, - !options.skipCommits, + options.createCommits, ); return success ? 0 : 1; @@ -539,7 +539,7 @@ export class UpdateCommand extends Command { migrateExternal: true, }); - if (success && !options.skipCommits) { + if (success && options.createCommits) { this.createCommit('Angular CLI update\n' + packagesToUpdate.join('\n'), []); } @@ -558,7 +558,7 @@ export class UpdateCommand extends Command { migration.package, migration.collection, new semver.Range('>' + migration.from + ' <=' + migration.to), - !options.skipCommits, + options.createCommits, ); if (!result) { diff --git a/packages/angular/cli/commands/update.json b/packages/angular/cli/commands/update.json index f9ef123e15cd..855ccb27574f 100644 --- a/packages/angular/cli/commands/update.json +++ b/packages/angular/cli/commands/update.json @@ -63,8 +63,8 @@ "type": "boolean", "default": false }, - "skipCommits": { - "description": "Do not create source control commits for updates and migrations.", + "createCommits": { + "description": "Create source control commits for updates and migrations.", "type": "boolean", "default": false, "aliases": ["C"]