-
Notifications
You must be signed in to change notification settings - Fork 1.8k
interferes with ui.bootstrap.typeahead #39
Comments
Hummm :/ Originally all ui-select directives were elements (E) only => no issue. If you have a directive that uses one or more directives, then you have no choice than to use attributes (A): angular/angular.js#4020 => clash name with ui.bootstrap.typeahead And I guess dropping IE8 support considering AngularJS 1.2 supports IE8, is a bit premature. |
@andrewboni @ProLoser @chmanie <ui-select>
<match></match>
<choices></choices>
</ui-select> <ui-select>
<ui-select-match></ui-select-match>
<ui-select-choices></ui-select-choices>
</ui-select> Most probably Bootstrap-ui will prefix all directives using ui- |
Works for me 👍 |
yes, that works, thanks! |
Any proposed timeline on this? I'm going to implement the short-term fix on this for now. |
See commit 777c804 |
@tkrotoff Could you release it? |
Could you re-build it ? |
Just hit this issue myself... +1 |
There's release on my fork if someone really needs it |
Oh. I see it was released 2h ago... A comment would be nice. |
Hi, I am still experiencing issues with this... I saw a comment above that a fix was released and available for version But even so, I get this whenever a view including the directive is loaded:
This is my {
"name": "merchantUi",
"version": "0.0.0",
"dependencies": {
"modernizr": "2.8.x",
"angular": "1.2.x",
"jquery": "1.x.x",
"angular-animate": "1.2.x",
"angular-cookies": "1.2.x",
"angular-touch": "1.2.x",
"angular-sanitize": "1.2.x",
"angular-resource": "1.2.x",
"angular-ui-router": "0.2.x",
"bootstrap-sass-official": "3.1.x",
"angular-bootstrap": "0.11.2",
"angular-loading-bar": "~0.5.2",
"angular-growl-v2": "~0.7.0",
"angular-ui-select": "0.8.1",
"angular-ui-tree": "~2.1.5"
},
"devDependencies": {
"angular-mocks": "1.2.x"
},
"resolutions": {
"angular": "1.2.22",
"angular-ui-select": "0.8.1"
}
} This is my angular app declaration: angular.module('merchantUI',
[
'ngAnimate', 'ngCookies', 'ngTouch', 'ngSanitize',
'ngResource', 'ui.router', 'angular-loading-bar',
'app.config', 'angular-growl', 'ui.select',
'ui.tree', 'ui.bootstrap'
]
) This is how I'm calling ui-select: <div class="form-group">
<label for="states">States Doing Business In</label>
<ui-select multiple ng-model="userMerchant.selectedStates" ng-disabled="disabled">
<ui-select-match placeholder="Select states...">{{$item.value}}</ui-select-match>
<ui-select-choices repeat="state.id as state in formItems.states | filter: { value: $select.search }">
<div ng-bind-html="state.value | highlight: $select.search"></div>
</ui-select-choices>
</ui-select>
<span class="help-block error" ng-show="companyProfileFormErrors.states" ng-repeat="error in companyProfileFormErrors.states">{{error}}</span>
</div> and this is how I'm calling typeahead (based on angular-bootstrap docs): <div class="form-group">
<label for="states">Assign user to these Locations</label>
<input type="text" ng-model="modalOptions.args.selectedLocations" typeahead="location for location in modalOptions.args.locations | filter:$viewValue | limitTo:8" class="form-control">
</div> |
@antillas21 can you put together a plunker to reproduce it? |
@dimirc ... ooh man, this is embarrassing, but I think I have identified the reason behind this... It's not related to your directive... it's related to a custom directive created in the project, which by the way is named Thanks for your time, and apologies for this incident. |
the
match
directive is restriced toEA
, which causes interference with the ui.bootstrap.typeahead directive which usesmatch=""
as an attribute.Just restricting the
match
directive of ui-select toE
should solve this, but in the long run maybe deciding on another name for thematch
directive would be reasonable (maybeselectMatch
).The text was updated successfully, but these errors were encountered: