fix(uiView): do not leave initial view scope undestroyed #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the contents of the initial view were linked and left undestroyed when the view was replaced with a subview. Because the view was not destroyed, directives like ngInclude assumed it was safe to compile and link asynchronous content to it. This would cause a ctreq error if the asynchronous content required another directive from the DOM. Now the initial view is either not linked at all or its scope is properly destroyed. Closes #1896
jpekkala
commented
Nov 21, 2016
| @@ -324,7 +324,7 @@ describe('uiView', function () { | |||
| }); | |||
|
|
|||
| it('should instantiate a controller with controllerAs', inject(function($state, $q) { | |||
| elem.append($compile('<div><ui-view>{{vm.someProperty}}</ui-view></div>')(scope)); | |||
| elem.append($compile('<div><ui-view></ui-view></div>')(scope)); | |||
There was a problem hiding this comment.
This test broke but not because of what it tests. The template property was not originally in the test and after this change the template property overwrites the initial view.
There was a problem hiding this comment.
I'm not sure what this was originally trying to test >_>
christopherthielen
pushed a commit
that referenced
this pull request
Dec 15, 2016
…ed rejection) This is a backport of #3164 from `master` to `legacy` Previously the contents of the initial view were linked and left undestroyed when the view was replaced with a subview. Because the view was not destroyed, directives like ngInclude assumed it was safe to compile and link asynchronous content to it. This would cause a ctreq error if the asynchronous content required another directive from the DOM. Now the initial view is either not linked at all or its scope is properly destroyed. Closes #3164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the contents of the initial view were linked and left
undestroyed when the view was replaced with a subview. Because the view
was not destroyed, directives like ngInclude assumed it was safe to
compile and link asynchronous content to it. This would cause a ctreq
error if the asynchronous content required another directive from the
DOM. Now the initial view is either not linked at all or its scope is
properly destroyed.
Closes #1896