Datepicker popup doesn't show in Angularjs 1.2.0rc2

[countableSet]

Looks like the popup for the datepicker no longer works in angular 1.2.0rc2.
I'm using a snapshot of angular-ui-bootstrap since there were some previous issues with datepicker in release 0.5.0. This is the commit I'm running off of: 015625d

Here's the plunker for the issue.

[hallister]

Unless this is new in RC2 this should be a duplicate of #813. Please feel free to let us know if you think this is a different issue.

[countableSet]

If you look at the plunker and change the angular include from rc2 to rc1- it worked in rc1 and now doesn't work in rc2. I don't see anything related to ng-bind-html-unsafe in the templates with datepicker.

[bekos]

@countableSet Indeed. Popup datepicker breaks by the fixes in ngTransclude introduced in rc2.
We will have to check again.

[pkozlowski-opensource]

@bekos do you know which AngularJS commit is at fault here? Is this something that should be taken with the AngularJS team?

[bekos]

@pkozlowski-opensource This is the commit that breaks it: angular/angular.js@bf79bd4

The weird thing is that our tests don't fail. Do you have any idea before debugging more closely? I am sure you know better than me :-)

[pkozlowski-opensource]

@bekos you are highly over-estimating my super-powers :-) I've got no idea what is going on here, I'm afraid....

[bekos]

No way @pkozlowski-opensource :-)

I think it has to do with the order of the transclusion, but I cannot be sure atm to open an issue to AngularJS.

Anyway, I believe it's better to avoid the transclusion in the popup template since there is no actual benefit. The difference, if someone wants to override the popup template, is instead of having a ng-transclude where we inject the datepikcer, he will have to write the datepicker element himself. I 'll open a PR for this.

[bekos]

Above fix is not valid :-(
I have to create the datepicker element and inject it in the template because I have to manipulate it first, like adding attributes.

[bekos]

The problem is that the ngModelController is not available in the linking function of the datepicker, after the $compile of <datepicker-popup-wrap>.

Here is a plunker with a reproduce scenario.

Again, if you replace the templateUrl with inline template in the test directive then there is no problem.

[bekos]

Opened issue in angular: angular/angular.js#3923

[boneskull]

I was able to workaround this by modifying some lines of code:

      // popup element used to display calendar
      var popupEl = angular.element('<datepicker-popup-wrap><datepicker></datepicker></datepicker-popup-wrap>');
      popupEl.attr({
        'ng-model': 'date',
        'ng-change': 'dateSelection()'
      });
      var datepickerEl = popupEl.find('datepicker');
      if (attrs.datepickerOptions) {
        datepickerEl.attr(angular.extend({}, originalScope.$eval(attrs.datepickerOptions)));
      }

becomes:

      // popup element used to display calendar
      var popupEl = angular.element('<datepicker-popup-wrap><datepicker></datepicker></datepicker-popup-wrap>');
      var datepickerEl = popupEl.find('datepicker');
      datepickerEl.attr({
        'ng-model': 'date',
        'ng-change': 'dateSelection()'
      });
      if (attrs.datepickerOptions) {
        datepickerEl.attr(angular.extend({}, originalScope.$eval(attrs.datepickerOptions)));
      }

But I don't know if that breaks anything else.

[bekos]

@boneskull It actually breaks everything else :-) but it's on the right track for a workaround.
The right change on your code would be like this:

datepickerEl.attr({
        'ng-model': '$parent.$parent.date',
        'ng-change': '$parent.$parent.dateSelection()'
 });

Anyway, we can have this in mind if nothing changes in rc3 that I hope to be soon.

[boneskull]

Awesome, thanks @bekos

[dotcom9]

I'm interested in developments on this thread

[pkozlowski-opensource]

@dotcom9 it was fixed in AngularJS via angular/angular.js#3923, things seem to be in order with the latest AngularJS from master: http://plnkr.co/edit/a292hNtkjeimxq6u6yle?p=preview

I guess we can close this one as the AngularJS fix will be available in RC3