Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Timepicker - Validation issue #6230

Closed
bifodus opened this issue Sep 7, 2016 · 1 comment
Closed

Timepicker - Validation issue #6230

bifodus opened this issue Sep 7, 2016 · 1 comment

Comments

@bifodus
Copy link
Contributor

bifodus commented Sep 7, 2016

Bug description:

When a bad value is entered in the timepicker, the input displays as invalid (that is, the class has-error is applied to the parent <td>, with which it can be styled as an error), but the class ng-invalid isn't applied to the input element itself (it will remain as ng-valid).

There may be other problems with this, but in my use case this conflicts with ngAria. ngAria will add the attribute aria-invalid to the element and set it to true or false based on the presence of the ng-valid or ng-invalid classes.

Reproduce the issue:

  1. View the Timepicker on the demo page
  2. Enter the value 'z' into the Hours input in the Start Time
  3. Inspect this input and notice the presence of ng-valid

Version of Angular, UIBS, and Bootstrap:

Angular: 1.5.2
UIBS: 2.0.2
Bootstrap: 3.3.1

@david-kirkland
Copy link
Contributor

david-kirkland commented Sep 21, 2016

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants