Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix open component modal jqlite compatibility #6187

Closed
wants to merge 1 commit into from
Closed

fix open component modal jqlite compatibility #6187

wants to merge 1 commit into from

Conversation

navarroaxel
Copy link
Contributor

fix issue #6186.
Works fine with legacy controller modals and component modals.

@navarroaxel navarroaxel changed the title fix open component modal using jqlite [without jquery] fix open component modal jqlite compatibility Aug 20, 2016
@navarroaxel
Copy link
Contributor Author

in jQuery the the .html() method calls .empty().append() internally.
in jqlite the .html() set the HTMLElement into the innerHTML attribute of the parent element, so the .toString() method is called and displayed into the rendered HTML.

The solution for this was call the .append() method directly and the .empty() is not necessary because the parent is new and empty.

@wesleycho wesleycho added this to the 2.1.1 milestone Aug 21, 2016
@wesleycho
Copy link
Contributor

Good catch! Thanks for the PR!

@wesleycho wesleycho closed this in fb5fabf Aug 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants