Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

UI Bootstrap Site - Modal scrollbar removal feature impact/side effects on navbar #6035

Closed
nazrhyn opened this issue Jun 20, 2016 · 6 comments

Comments

@nazrhyn
Copy link

nazrhyn commented Jun 20, 2016

Bug description:

From the searching I've done, this is apparently "the issue that never dies". I did read your guidelines, but I'm not providing you with a plunkr, as it's happening on your site (watch the navbar title text):

bootstrap-modal-shift

From what it looks like, the container gets the padding added, but the scrollbar is also affecting the navbar's contents, which does not receive padding modifications, so the contents of the navbar shift to the right.

I'm investigating a similar issue in our code that is also related to the scrollbar padding system; in our case, I am pretty sure it's related to how we arrange our containers, but if I find anything that I can reproduce for you, there, I'll make a plunkr. I thought I'd submit this one first as, if you fix this, it might fix our issue.

I will understand if you close this for not providing code, but I didn't want to manually duplicate the layout of your site to let you know what was going on when I could just point my finger 😀.

Thanks for such an awesome library; we love it.

@icfantv
Copy link
Contributor

icfantv commented Jun 20, 2016

@RobJacobs, i could have sworn this was addressed? Or is this a different issue? Thanks.

@RobJacobs
Copy link
Contributor

See my comment in #5749

@icfantv
Copy link
Contributor

icfantv commented Jun 20, 2016

@RobJacobs sweet, thanks! @nazrhyn, please look at the linked Issue above to see if it helps you with your issue. I'm going to close this in the interim but will reopen if it can be shown it's a different issue.

@nazrhyn
Copy link
Author

nazrhyn commented Jun 20, 2016

@icfantv Thanks for the pointer. I assume the main site is just not following this advice yet?

@icfantv
Copy link
Contributor

icfantv commented Jun 20, 2016

@nazrhyn, ummmmmmmmmmm........that would probably be a safe assumption..... :-(

@nazrhyn
Copy link
Author

nazrhyn commented Jun 20, 2016

Haha. 😇

I figured out the minimal case on my issue with one of our UI developers and opened the real issue, anyway. Hopefully I don't waste your time again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants